docs: design deterministic fuel evidence - #1196
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 31, 2026, 11:21 AM ET / 15:21 UTC. ClawSweeper reviewWhat this changesThis PR adds a detailed design for deterministic Wasmtime-fuel evidence and changes the existing future timing-schema example from an Merge readinessKeep this PR open for maintainer product-direction review. The supplied context shows a documentation-only proposal that would make a Priority: P3 Review scores
Verification
How this fits togetherCrabbox runs checks in disposable provider-backed environments and records artifacts for CI-facing evidence. This proposed documentation defines how a future deterministic performance gate would meter a WASI test workload, validate its artifact, and feed that evidence into existing artifact collection. flowchart LR
A[Workflow policy tests] --> B[WASI test binary]
B --> C[Pinned metering helper]
C --> D[Wasmtime fuel measurement]
D --> E[Versioned evidence artifact]
E --> F[Crabbox artifact validation]
F --> G[Future CI regression gate]
Decision needed
Why: This PR intentionally chooses user- and machine-facing artifact terminology while deferring several compatibility and product-surface decisions; source review alone cannot choose that permanent direction. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Confirm the permanent evidence-schema and compatibility direction, then land one coherent documentation contract that distinguishes stable artifact fields from implementation details deferred to a later runtime PR. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a documentation-only design proposal, not a report of failing current behavior. The supplied context includes compile and repository-gate claims, but local execution and source inspection were unavailable. Is this the best way to solve the issue? Unclear: the design is internally presented as phased, but maintainers must first decide whether the proposed fuel-specific artifact vocabulary and runtime boundary are the right permanent contract. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 5aa1c3983874. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (6 earlier review cycles)
|
Summary
wasip1/wasmbuild and guest commandsThis is documentation only. It adds no runtime code, flags, dependencies, release files, or changelog entry.
Verification
Proposed workload compilation:
Repository gates:
Embedded JSON proof:
Structured review:
Live CLI proof is not applicable because the change is docs-only. The proposed real workload was compiled to a WebAssembly test binary as shown above; executing it under Wasmtime is deliberately phase-one implementation work because Crabbox does not yet ship that runtime helper.
Open decisions
The design leaves the helper distribution channel, whole-module versus exported-function metering, phase-two CLI surface, cross-host proof matrix, and Wasmtime-upgrade versioning policy for maintainer approval before runtime implementation.