chore(deps-dev): bump @napi-rs/cli from 3.8.6 to 3.9.0 in the development group - #226
chore(deps-dev): bump @napi-rs/cli from 3.8.6 to 3.9.0 in the development group#226dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the development group with 1 update: [@napi-rs/cli](https://github.com/napi-rs/napi-rs). Updates `@napi-rs/cli` from 3.8.6 to 3.9.0 - [Release notes](https://github.com/napi-rs/napi-rs/releases) - [Commits](https://github.com/napi-rs/napi-rs/compare/@napi-rs/cli@3.8.6...@napi-rs/cli@3.9.0) --- updated-dependencies: - dependency-name: "@napi-rs/cli" dependency-version: 3.9.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Codex review: needs changes before merge. Reviewed September 4, 2026, 1:29 PM ET / 17:29 UTC. ClawSweeper reviewWhat this changesThis PR updates the development-only @napi-rs/cli native-addon build tool from 3.8.6 to 3.9.0 and refreshes its pnpm lockfile resolution. Merge readiness⛔ Needs changes before merge - 2 items remain Keep open. The update is narrow and mechanically consistent, but it needs the required Unreleased changelog entry for a native build-tool/package change before merge. Priority: P3 Review scores
Verification
How this fits togetherThe native build workspace invokes the N-API CLI to compile fs-safe’s platform bindings. Those bindings are assembled into the published package and provide the optional native implementation behind the filesystem-safety API. flowchart LR
A[Native Rust source] --> B[N-API build CLI]
B --> C[Platform native bindings]
C --> D[Package assembly]
D --> E[Filesystem-safe API consumers]
Before merge
Findings
Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Retain the pinned update, add a concise Unreleased changelog note for the native build CLI refresh, and rely on the existing cross-platform native and package checks before landing. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR updates build tooling rather than reporting a user-facing defect. Is this the best way to solve the issue? No: the version and lockfile update are appropriately narrow, but repository policy also requires an Unreleased changelog entry for this package/operational change. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 3afa58251b49. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Bumps the development group with 1 update: @napi-rs/cli.
Updates
@napi-rs/clifrom 3.8.6 to 3.9.0Commits
f4cbe8dchore(release): publish9c23c8cchore(deps): update dependency oxc-parser to ^0.148.0 (#3475)a472725chore(napi): keep anyhow error cause when converting (#3477)2d40a52feat(cli): add explicit build module format (#3463)56c1cceperf(napi): outline threadsafe callback dispatch (#3465)57826b9perf(napi): outline class instance construction (#3464)a80018efix(napi): catch panics in closure trampolines instead of aborting (#3473)cfc2a9cperf(sys): deduplicate dynamic symbol loading (#3466)9b24b06chore(deps): update cross-platform-actions/action action to v1.5.0 (#3471)b494accfix(deps): update rust crate convert_case to 0.12 (#3469)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions