fix: secure Windows reads reject foreign file owners - #48
Merged
Conversation
…rust # Conflicts: # CHANGELOG.md
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix: secure Windows reads reject foreign file owners This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes an issue where Windows secure-file consumers could accept a file with a restrictive ACL even when an untrusted principal owned the file and could later change that ACL. Ownership and ACL classification also depended on localized principal names in several paths, and extended Windows path namespaces were not classified consistently.
Why This Change Was Made
Resolve Windows owners and ACL principals to canonical SIDs through absolute system commands, then require ownership by the current user, LocalSystem, or Administrators for secure reads. Unknown owners, remote volumes, non-drive extended namespaces, lookup failures, and foreign owners fail closed. Exact extended drive paths such as
\\?\C:\...remain supported.This opens the
0.4.6changelog section but intentionally leaves package publication/versioning to the normal post-merge release flow.User Impact
Windows applications using fs-safe can rely on secure reads rejecting foreign-owned or unverifiable files. Local extended drive paths continue to work, while UNC, MUP, device, volume-GUID, and malformed namespaces remain blocked from local-only reads.
Evidence
pnpm checkon macOS: build, file-size and filesystem-boundary gates passed; 43 test files and 459 tests passed.readSecureFileproof passed for an exact extended local path (\\?\C:\...).DriveInfocompatibility concern was rejected because the exact Windows PowerShell path passed twice in native execution.