fix(ci): continue release after registry miss - #54
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(ci): continue release after registry miss This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Member
Author
|
Release recovery decision:
After this repair merges, delete and recreate the protected signed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes an issue where the protected release workflow exited before
npm publishwhen the requested package version was correctly absent from the registry.
The first
v0.4.6run validated the tag, changelog, package, tests, and tarball,then failed in the publish/recovery step:
https://github.com/openclaw/fs-safe/actions/runs/30086619672
Why This Change Was Made
Keep
errexitcontrol at the two existing call sites. The registry verificationhelper no longer re-enables it internally before returning the expected E404
status, so the workflow can proceed into npm trusted publishing.
User Impact
This unblocks publication of
@openclaw/fs-safe@0.4.6. Runtime package behavioris unchanged by this repair.
Evidence
Executed the exact embedded publish block with a fake registry:
E404 before publish, matching integrity and provenance after publish; exit 0.
git diff --checkAutoreview: clean, no accepted or actionable findings.
The failed release run completed all validation and package checks before the
affected publish/recovery step.
Tests added or updated when behavior changed
Security and compatibility impact considered
CHANGELOG.mdupdated when release-relevantNo credentials, private paths, private hosts, or sensitive contents included