Repository navigation
chore(release): cut 0.4.11 - #56
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 13, 2026, 10:26 PM ET / September 14, 2026, 02:26 UTC. ClawSweeper reviewWhat this changesUpdates the macOS signing helper used by release tooling and combines the 0.4.11 recovery notes with the unpublished 0.4.10 changes, with focused regression coverage. Merge readiness✅ Ready for maintainer review This recovery release remains necessary: main retains the older signing-helper pin, and the latest published release is v0.4.9. No actionable defect was found in the proposed changes; the collaborator-authored PR should remain open. Priority: P2 Review scores
Verification
How this fits togetherThe local release producer turns verified source tags into signed release binaries and GitHub release notes. It checks a pinned external signing helper before execution and verifies release-note contents throughout draft creation and publication. flowchart TD
A[Verified source tag] --> B[Local release producer]
C[Pinned signing helper] --> B
D[Tagged changelog] --> E[Recovery note assembly]
B --> F[Signed release draft]
E --> F
F --> G[Verification and publication]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Retain the narrowly scoped helper correction and recovery notes within the existing signed, draft-first release process. Do we have a high-confidence way to reproduce the issue? Yes at the source level: the producer supplies an isolated HOME, while the old helper runs its signing canary before restoring the account home. The PR reports a successful corrected canary; this review did not execute macOS signing. Is this the best way to solve the issue? Yes. The pin update adopts a verified one-line dependency correction, and the version-specific note rollup reuses the existing extraction and verification path. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against ce57ab1d32a8. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Recover signed macOS releases after v0.4.10 stopped before creating binaries. Pin the landed shared-helper correction that resolves the login home for the Developer ID signing canary; the canonical helper now passes a real canary from an empty isolated HOME.
Add the finalized 0.4.11 changelog entry. The producer appends the complete dated 0.4.10 section to 0.4.11 release notes and verifies that same combined body throughout draft and publication. Regression coverage checks exact ordering, ordinary releases, and missing or duplicate recovery sections. Versions continue to derive from the immutable release tag and Go module metadata.
Validation: Go 1.26.8 build, lint, tests, coverage, documentation metadata, isolated-home signing canary, and independent P0–P2 autoreview passed. The full contract rerun and exact-head PR CI must pass before merge. The v0.4.10 tag remains unchanged. Homebrew remains held by the existing Formula/Cask handoff contract.