fix: support group participant changes on macOS 26#178
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 18, 2026, 4:24 AM ET / 08:24 UTC. Summary Reproducibility: no. high-confidence live reproduction was established in this review because the reported behavior needs a macOS 26 Messages.app account and disposable group. The source path is clear, and the PR describes the required add/list/remove round trip, but no inspectable after-fix artifact was supplied. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Keep the service-aware resolver and selector-fallback implementation, then attach redacted evidence from a disposable macOS 26 group showing add, fresh chat listing, remove, and restoration of the original participant set before merge. Do we have a high-confidence way to reproduce the issue? No high-confidence live reproduction was established in this review because the reported behavior needs a macOS 26 Messages.app account and disposable group. The source path is clear, and the PR describes the required add/list/remove round trip, but no inspectable after-fix artifact was supplied. Is this the best way to solve the issue? Yes, conditionally: preferring the macOS 26 selectors behind runtime availability checks and retaining legacy fallbacks is the narrowest maintainable repair. It should not merge until real macOS 26 evidence confirms both the selected path and observed membership result. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against ca91c41b47e0. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix: support group participant changes on macOS 26 This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Summary
IMHandleWithID:inviteParticipants:reason:andremoveParticipants:reason:with the older selectors as fallbacksstatus --jsonVerification
make build-dylibmake test(477 tests)+13129001215to a disposable 3-member group, verify via a freshimsg chats, remove it, verify the original participant set is restored