Repository navigation
fix(ci): isolate daemon elicitation and refresh dependencies - #461
Merged
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default-branch Windows CI run failed in
daemon-elicitation.test.ts: process ownership capture left the broker inretirement-failed, and teardown's refusal to stop masked the initial observation error. The elicitation assertions should exercise the MCP exchange independently of Windows process-query availability.Stub only the ownership/retirement helpers in this test, retaining the real server, transport, broker, and elicitation response. Dedicated process-retirement unit and real process-tree integration tests remain enabled on every CI platform. Also ensure the temporary config directory is removed if broker cleanup fails. Production ownership checks and fail-closed shutdown behavior are unchanged.
Refresh jose to 6.2.13, Oxlint to 1.89.0, and Oxfmt to 0.74.0. All three versions clear the 48-hour dependency cooldown and retain the Node 24 runtime floor; the lockfile preserves the MCP client patch and security overrides. No package version change or release.
Validation:
pnpm install --frozen-lockfile,pnpm check, andpnpm test --maxWorkers=2pass (2,275 passed, 27 skipped across 255 files).