Repository navigation
Conversation
A baseUrl whose text starts with http: or https: followed by one or no
slash (https:/v1, https:v1, https:${HOST}, https:{{ vars.host }}) is now
refused with "Configuration field <field> must start with https:// or
http:// (the // after the scheme is missing)." instead of the general
"must be an absolute http or https URL." Every other baseUrl refusal,
including an empty host (https:///v1) and a fallback that renders a
one-slash URL, keeps the general message. Finding 1285.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review blockedAutomated review did not run, so no review verdict was produced. Reason: The input-safety check rejected material in this revision. No detected value, path, or scanner output is reproduced here. Automatic review is on hold, including after source changes. Request a fresh re-review after resolving the failure; maintainers can also release the hold through an intentional scanner-policy update. Next step: If this is a genuine credential, remove and rotate it. If it is an intentional test fixture, a maintainer must review and qualify it. |
freeqaz
had a problem deploying
to
integration-qa-pr
October 14, 2026 00:58 — with
GitHub Actions
Error
freeqaz
had a problem deploying
to
integration-qa-pr
October 14, 2026 00:58 — with
GitHub Actions
Error
…t a string A JSON array such as ["https:/v1"] made text that starts with an http scheme and got the missing-// message, though its problem is its type. Review finding on #2375.
freeqaz
temporarily deployed
to
integration-qa-pr
October 14, 2026 01:04 — with
GitHub Actions
Inactive
freeqaz
temporarily deployed
to
integration-qa-pr
October 14, 2026 01:04 — with
GitHub Actions
Inactive
This was referenced Oct 14, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#2351 refuses a model
baseUrlthat writes one or no slash after itshttp:orhttps:scheme (https:/v1,https:v1,http:/host,HTTPS:/host,https:${HOST},https:{{ vars.host }}). The refusal names the field but says onlyConfiguration field <field> must be an absolute http or https URL.A value such ashttps:/models.example.test/v1reads as absolute to a person, so the message does not say what to fix. The breaking-changes notice says to write//after the scheme; the save response does not.Change
packages/occ/src/errors.ts: a newbaseUrlSlashesmessage forModelProviderSettingError:Configuration field <field> must start with https:// or http:// (the // after the scheme is missing).It keeps the field path and never echoes the value.packages/occ/src/model-provider-settings.ts: when abaseUrlis refused and its text up to the first Preset variable starts with an http(s) scheme (any case, after leading spaces or controls, ignoring tabs and newlines as the URL parser does) followed by anything other than two slashes or backslashes, the refusal uses the new message. Every other refusal keeps its text, including an empty host (https:///v1), another scheme (ftp://...), a non-URL, a${VAR:-https:/v1}fallback (the value does not start with the scheme), and a value that is not a string, such as["https:/v1"].serverMessage), so it needs no copy change.docs/guides/deploy/breaking-changes.md: the 2026-10-13 "How to tell" lists the new message (2467 words by the docs counter).Verification
tests/integration/configuration-controller.test.mjs: "Preset and Configuration saves refuse a baseUrl or api that a variable fills with no host or no string" now pins the new message forhttps:/models.example.test/v1,https:v1,http:/models.example.test,\tHTTPS:/models.example.test,https:\models.example.test,https:${MODEL_HOST}/v1, a model'shttp:/${MODEL_HOST}, Presethttps:{{ vars.h }}andHTTPS:/{{ vars.h }}/v1, and a launch filled withhttps:/v1.https:///v1,HTTP:\\\v1,http:////...the${MODEL_URL:-https:/...}fallback and an array["https:/v1"]still get the general message.taskset -c 0,1); the full file 97/97 at 2 CPUs.tsc --build, eslint--max-warnings 0and prettier--checkon the touched files: clean.Risks
Low. Message text only; which values are refused does not change. Clients that matched the old text exactly for these shapes see the new sentence.