Repository navigation
Add an opt-in protected local Kubernetes launch profile - #2450
freeqaz-openai wants to merge 5 commits into
Conversation
…ess-installed-20261014
…ess-installed-20261014 # Conflicts: # docs/testing/static-egress.md
…ess-installed-20261014
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Found 1 test failure on Blacksmith runners: Failure
|
| cert: readFileSync(identity.certPath), | ||
| ca: readFileSync(ca.certPath), | ||
| requestCert: true, | ||
| rejectUnauthorized: false, |
|
Codex review: needs real behavior proof before merge. What this changesThis PR adds a default-off Kubernetes/OpenShell launch profile with administrator mTLS, authority TLS, scoped credential mounts, and dependency-aware startup ordering. Example: Launch Kubernetes Compute and control plane with OpenShell and OCC_DEVELOPMENT_PROTECTED_EGRESS=1.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Blocked before merge - 5 items remain Keep this PR open for maintainer triage: it adds a distinct, explicitly held development capability, and no definite introduced production defect was identified. Priority: P2 Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherThe development CLI turns operator selections into Installation configuration and Helm resources; the resulting API and worker administer OpenShell while supervisors call the API-owned credential authority. flowchart TB
A[Operator selections] --> B[Development CLI]
B --> C[Installation and Helm inputs]
C --> D[API and worker]
D -->|Administrator mTLS| E[OpenShell Gateway]
C --> F[API credential authority]
E -. Supplier integration .-> G[Trusted supervisors]
G -. Signed requests .-> F
Technical reviewBest possible solution: Land the default-off profile with published, revision-matched supplier artifacts after its installed security and lifecycle boundaries are qualified. Do we have a high-confidence way to reproduce the issue? This PR adds a capability rather than repairing a reproduced bug; current-main inspection confirms the protected launcher and mTLS mode are absent. Is this the best way to solve the issue? Extending the existing launcher, Backend, and Helm composition is coherent and preserves ordinary defaults, but installed supplier behavior remains unqualified. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against a28596ab8cf5. Merge-risk optionsMaintainer options:
Provenance checked
TestingProof path: in-process harness. SecurityNeeds attention: Source preserves credential separation and TLS verification, but supplier administrator authorization and final-effect enforcement remain unqualified. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 14, 2026, 1:39 PM ET / 17:39 UTC. |
A local Kubernetes/OpenShell launch needs a protected path that starts the egress authority and gateway with the identities and trust they require. This draft adds an explicit, default-off profile for that setup. Existing launch defaults and exact image and version gates remain unchanged.
The profile is a further implementation slice of RFC #1530, building on the core egress draft and the connected qualification and public CA slice. It also needs the companion OpenShell chart changes before the combined path can be qualified.
Validation: 181 Go owner tests passed with no skips, using the actual CLI, normal dependency checksums and Helm renders. The regression exercises both entrypoints: all 24 incompatible-profile cases reached the old launcher before the fix and now fail before effects; eight ordinary-profile controls still pass. The combined predecessor passed 463 selected integration/conformance cases, including genuine local TLS/WSS success and refusal tests, plus TypeScript, lint, formatting, workspace, documentation and OpenAPI checks. The final merge adds the reviewed entrypoint guard; matching controller/runtime images and CLI build successfully.
Remaining work: Independent source review found no remaining actionable issues in the launch guard. The companion OpenShell chart and runtime changes are local and unpublished. The normal protected local stack starts successfully, including PostgreSQL and the launcher’s network-isolation checks. The connected E2E run failed at Agent activation: OpenShell rejected Sandbox creation with gRPC 3, and the worker exhausted its dependency attempts. No provider request was sent. Test resources and the owned stack were cleaned up; a safe diagnostic correction is in progress. Authorization/rotation/response cases and real-provider dogfood remain unverified. Enrollment is initial-startup only; recovery after a Harness restart requires a new revision. This draft does not establish high availability, complete RFC implementation or production qualification.