[freeqaz]

Problem

A mutation sweep checked the rules that landed on 10-14 afternoon: #2430, #2437, #2442, #2436, #2446 and the Slack part of #2439. Their own tests left some conditions unpinned. The suites killed 44 of 77 mutants. Each real survivor is a regression that would ship green:

• Status read (fix(controller): refuse deploys over unreadable revisions and read oversized status errors by code #2430, fix(kubernetes): settle redirected status reads promptly #2442). The tests only checked early 3xx classification with a 302. If the range shrinks, a 300 or 399 with a held-open body hangs the read. Nothing tested the edges of the range: a 299 parses and a 400 is not a redirect. Nothing tested the oversized-2xx edge either: a 299 over the limit is refused.
• Shared non-redirecting HTTP library (fix(kubernetes): refuse redirects on controller API and Pod proxy reads #2437). It replaces client-node's own library for every client, but only GET reads were tested. Dropping the request body, sending every request as GET, or dropping the cancellation signal all passed.
• Numeric last-label hint (fix(configuration): explain the numeric last label refusal on model baseUrl #2436). The hint finds the host the way the URL parser does. Several parts of that were untested:
  • leading and trailing C0/space trimming
  • backslashes after the scheme
  • skipping userinfo
  • uppercase 0X and a bare 0x
  • the label regex's anchors: a label that only starts or ends with digits keeps the general message
  • a Preset whose last label comes after a variable
• Superseded rendering (fix(console): show a superseded deployment as superseded, not failed #2446). Nothing rendered REPOSITORY_REVISION_SUPERSEDED. Nothing asserted the neutral stage descriptions or the version record's neutral note.

Change

Test-only. Rows and assertions sit next to the existing tests, with no new helpers.

• tests/conformance/bounded-response-reads.test.mjs
  • The oversized test (finding 1327) and the in-limit parse test now run for 200 and 299.
  • New: a 300 or 399 with a held-open body settles as a redirect.
  • New: a 400 surfaces as the client's error, not a redirect.
• tests/conformance/kubernetes-client.test.mjs: one test, appended at the end. A createNamespace through the shared clients sends POST with its JSON body. A read the server holds open stops when the operation's signal aborts mid-request.
• tests/integration/configuration-controller.test.mjs
  • Seven Configuration rows expect the numeric-host message. The userinfo row uses syntheticCredentialUrl.
  • Two rows expect the general message (api.a<1, api.1<a).
  • One Preset row expects the numeric-host message.
• tests/browser/console-agent-state.test.mjs: the superseded test now asserts the two neutral stage descriptions and the version record's neutral note. It ends with a refresh to REPOSITORY_REVISION_SUPERSEDED, which renders neutral with the status line hidden.

Verification

• Kill table. 77 mutants: 44 killed before, 68 after. A new row or assertion kills each of the 24 newly killed mutants, and each passes on main.
• The 9 survivors are equivalent:
  • K1, K3, K5: the oversized branch never sees a 1xx or 3xx.
  • K17: the awaited cancel sits inside a try/catch and resolves promptly. The existing held-open test shows it.
  • K20: the 3xx fallback in the catch block can't be reached while the middleware classifies 3xx first.
  • R12: none of the client-node APIs the controller calls reads binary().
  • N18: a value holding an environment reference is refused only for its slashes, which leaves the hint an empty host.
  • S2: Slack set to manual also reports unavailable after one request.
  • U3: the API sets error only on a failed status.
• 20/20 pinned runs (taskset, 2 CPUs) of each touched file on the final head: console-agent-state 20/20 (22-35 s), configuration-controller 20/20 (5.5-7.2 s), kubernetes-client 20/20 (6.2-7.2 s), bounded-response-reads 20/20 (2.0-2.3 s).
• Format and lint. prettier --check is clean on the touched files; I first confirmed it fails on an unformatted file. eslint is clean.
• Not run. Docker conformance, PostgreSQL (postgres-platform-state) and a live cluster aren't needed for these rows.

Risks

Test-only.

• The new status-read tests bound their waits at 4 to 8 s.
• The cancellation test aborts when the server receives the read, so it doesn't depend on timing. It allows 3 s.
• One redirect test relies on holdingServer sending a single 64 KiB chunk, which is within the status limit. A comment says so.
• The branch merges main, including fix(credentials): refuse hosts-file loopback token_url hosts and stop retrying 1xx status reads #2447, conflict-free. The other open PR touching these files (feat: assign configured OpenClaw roles to Agent users #906) gains no new conflicted file.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs maintainer review before merge.

What this changes

This PR expands tests for runtime status boundaries, Kubernetes request forwarding and cancellation, numeric-host validation hints, and superseded deployment rendering.

Example: The shared Kubernetes HTTP library accidentally sends GET instead of POST when creating Namespace tenant.

• Before: Existing GET-focused coverage could miss the regression.
• After: The new test checks the received POST method and Namespace JSON body.

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	Useful, source-consistent regression coverage with passing relevant CI; evidence remains test-harness based rather than independently substantiated mutation results.
Proof confidence	🦐 gold shrimp (3/6)	This maintainer-authored, test-only PR changes no shipped behavior; passing exact-head CI supports the added cases without establishing live-cluster or deployment proof.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Test only · Worth it: Yes · Fix scope: Complete
User problem: Regressions in existing controller and console behavior can escape the current test assertions.
Reason: The additions protect distinct boundary and transport failures while preserving the existing product contracts.

Merge readiness

✅ Ready for maintainer review

Keep this PR open for maintainer triage: it adds useful regression coverage without changing production behavior, and no actionable introduced defect was found.

Priority: P3
Reviewed head: 0efa1b6eb415319981a84647b787689de0be839e

Before merge

None.

Findings

None.

Tests

• Missing end-to-end proof: The reported mutation improvement is not accompanied by per-mutant execution artifacts; the additions intentionally pass on the unmutated base.

Agent review details

How this fits together

These suites exercise Kubernetes transport and status readers, Configuration and Preset admission, and console deployment rendering, turning controlled HTTP responses and deployment records into observable assertions.

flowchart TD
  A[Regression scenarios] --> B[Kubernetes SDK and shared client]
  A --> C[Configuration and Preset API]
  A --> D[Console browser]
  B --> E[Loopback HTTP and TLS servers]
  C --> F[Admission and validation]
  D --> G[Deployment rendering]
  E --> H[Observable assertions]
  F --> H
  G --> H

Loading

Technical review

Best possible solution:

Retain these focused cases in the existing suites and keep production behavior owned by the current implementations.

Do we have a high-confidence way to reproduce the issue?

This is regression-test expansion rather than a current product bug; source inspection confirms the covered paths, and no target code was run during review.

Is this the best way to solve the issue?

Extending the owning suites is appropriate: the cases observe real transport, API responses, and rendering without adding production seams or duplicating implementation logic.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 1b5d06c039bc.

Provenance checked

• Bounded runtime status tests keeps the original intent (10fcfd8: Bound upstream reads and prevent oversized or unfinished responses from hanging the controller.)
• Kubernetes transport coverage keeps the original intent (ad37118: Refuse redirects while preserving the SDK's method, body, authentication, dispatcher, and cancellation behavior.)
• Numeric-host validation assertions keeps the original intent (6d04d87: Explain numeric-last-label parsing failures without changing accepted inputs.)
• Superseded deployment assertions keeps the original intent (807f758: Render superseded deployment records neutrally while preserving genuine failures and revision visibility boundaries.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

• Verified introduced scope: The pinned introduction changes only four test files, with 156 additions and 24 deletions; it adds no runtime, dependency, workflow, or persistence changes. (0efa1b6eb415)
• Distinct status boundary coverage: The additions preserve the existing 200 cases and cover oversized and parsed 299 responses, held-open 300/399 responses, and a 400 client error against the real status reader. (tests/conformance/bounded-response-reads.test.mjs:194, 0efa1b6eb415)
• Real SDK transport coverage: The new case uses production client construction and a TLS loopback server to inspect the createNamespace method/body and abort an already-dispatched read. (tests/conformance/kubernetes-client.test.mjs:603, 0efa1b6eb415)
• API and browser assertions match existing contracts: Configuration rows exercise real admission responses and construct userinfo through syntheticCredentialUrl; browser additions check neutral superseded descriptions and the second supported superseded code. (tests/integration/configuration-controller.test.mjs:4730, 0efa1b6eb415)
• Preserved original intent: The additions reinforce the contracts established by fix(kubernetes): refuse redirects on controller API and Pod proxy reads #2437, fix(kubernetes): settle redirected status reads promptly #2442, fix(configuration): explain the numeric last label refusal on model baseUrl #2436, and fix(console): show a superseded deployment as superseded, not failed #2446; the discussion on the redirect repair also records its before-and-after transport behavior.
• Current-main comparison: Fetched main does not contain these added cases; its intervening test change concerns ci-cleanup rather than the four touched suites. (1b5d06c039bc)

Likely related people:

• Free Wortley: Raw commit ad37118 adds tests/conformance/kubernetes-client.test.mjs:458 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: ad37118035e5; files: tests/conformance/kubernetes-client.test.mjs)

Review metrics

Metric	Value	Why it matters
Change distribution	Production +0/-0; tests +156/-24	Growth is confined to distinct regression scenarios and extensions of existing cases.

Labels

Label changes:

• add P3: This is test maintenance protecting already-implemented behavior, with no current runtime repair.
• add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

• P3: This is test maintenance protecting already-implemented behavior, with no current runtime repair.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 14, 2026, 1:58 PM ET / 17:58 UTC.