Repository navigation
test(openshell): report revision Pod readiness after native provisioning times out - #2677
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Free’s clanker here. I verified what the new diagnostic can distinguish through the real controller, authorization, worker and a disposable PostgreSQL database. Compute supplied controlled observations; no Kubernetes or OpenShell result is claimed. The original provisioning deadline still failed in every case, including when the later read found both Pods ready.
The malformed case was useful: my first fixture accidentally used an invalid Kubernetes name and UID, and the controller correctly rejected it. I kept that negative and used valid synthetic identities for the positive cases. Pod names, UIDs, event text and resource identifiers did not appear in the diagnostic. With the previous helper the same real handoff stopped after reading the deployment; it never requested runtime status. Separately, with the actual HTTP client and a deliberately incomplete second response, the runtime read began 3.13 seconds into the existing five-second diagnostic allowance and the connection closed at 5.01 seconds. A different reviewer checked the source, outgoing text and adverse cases. The repository review helper was invoked, timed out at 120 seconds and returned no verdict. The useful next result is the first-Agent case in this head’s OpenShell advisory, not just a green required summary. Issue #2658 stays open: this samples what is visible after the timeout, not a reconstruction of what caused it. |
|
Codex review: needs maintainer review before merge. What this changesThis PR reports revision-specific Gateway and Agent Pod readiness after native provisioning misses its deadline. Example: After eight minutes, provisioning is in handoff and its deployment reports REVISION_INCOMPLETE.
Review scores
ProductKind: Test only · Worth it: Yes Merge readiness✅ Ready for maintainer review Keep this PR open: it adds a useful, narrowly scoped diagnostic without weakening acceptance, and no introduced correctness defect was found; collaborator authorship also requires maintainer triage. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe first-Agent acceptance test reads the existing deployment runtime API through its authenticated controller client and reduces revision-bound observations to safe failure diagnostics. flowchart LR
A[First Agent acceptance test] --> B[Provisioning deadline]
B --> C[Exact deployment status]
C --> D[Authorized runtime API]
D --> E[Kubernetes Compute observations]
E --> F[Bounded readiness summary]
F --> G[Original deadline failure]
Technical reviewBest possible solution: Retain this bounded diagnostic while tracking the actual provisioning repair separately in #2658. Do we have a high-confidence way to reproduce the issue? Current-main source confirms that deadline diagnosis stops at deployment progress without reading runtime readiness; the author reports a failing-before/passing-after regression, but this review executed no target code. Is this the best way to solve the issue? Using the existing revision-bound runtime endpoint is an appropriate diagnostic extension because it preserves authorization, redaction, the shared read budget, and the original acceptance failure. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 7138a024fdd0. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 16, 2026, 11:07 PM ET / October 17, 2026, 03:07 UTC. |
|
The real OpenShell advisory ran on this exact head, and the diagnostic did its job without converting the failure to a pass.
Exact evidence and next discriminator are on issue #2658. Pod readiness after a timeout is not proof that the worker observed readiness before it, that a workspace node connected, or that provisioning is fixed. |
In first-Agent run 38988219736, both Compose and k3d reached the eight-minute provisioning deadline in handoff. The matching deployment reported
REVISION_INCOMPLETE, which can cover a Gateway still starting, a dedicated Harness that does not exist yet, or a later readiness check. The saved Pod listing did not identify this workload. Related to #2658.On that specific failure, read the deployment’s existing runtime status once, within the diagnostic time already allowed. Report how many Gateway and Agent Pods the response included (zero, one, or multiple) and, for a single Pod, its phase and Ready condition. A denied, malformed, or wrong-revision response leaves runtime status unavailable. The test still fails at the original acceptance deadline, even if this later sample finds both Pods ready.
The regression failed against the previous helper because it never requested the candidate’s runtime status. The first-Agent test file then passed its three local tests, with the opt-in installation test skipped. ESLint and Prettier passed for both changed files. A real Compose or k3d run is still needed to locate the stall.