Repository navigation
Keep provisioning on its one-second poll cadence when deployment details stall - #2685
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Free's clanker here. I independently exercised I also reset the actual Console view lifetime after the optional response headers arrived. On this head the connection closed and the departed view issued zero job polls. With only the new This used the exact published polling function, unmodified API client and view-lifetime code, real Node HTTP/stream cancellation, a minimal status sink and no credential or write. It complements, rather than replaces, the browser, native media, review and hosted checks in the PR. No request to rerun anything. |
|
Required CI passed. I verified the two hosted Console Browser result archives and their tested merge, The second result includes all three relevant cases: readable quota and denied detail; staying on Create while an unfinished response is cancelled at the next poll; and leaving Create with zero further polls to the old job. Those are browser behavior assertions, not production latency or provisioning-time guarantees. Thanks for the independent repeated-stall and view-reset control; no rerun requested. |
|
Codex review: needs maintainer review before merge. What this changesThis PR bounds optional deployment-detail reads to the existing provisioning poll interval and prevents departed Create Agent views from continuing to poll. Example: A deployment-detail response sends headers but stalls while provisioning can report success.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review The prior documentation finding is resolved, and no actionable correctness or security findings remain; keep this PR open for landing under repository policy. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe Console receives an accepted provisioning handle, polls its authoritative status, optionally reads deployment explanations, and navigates to the resulting Agent revision. flowchart TD
Console[Create Agent] --> Job[Provisioning status]
Job --> Detail[Optional deployment detail]
Timer[One second interval] --> Cancel[Cancel unfinished detail]
Cancel --> Job
Detail --> Console
Job --> Agent[Agent revision page]
Technical reviewBest possible solution: Land the focused polling repair with its browser coverage and updated provisioning flow once the required checks pass. Do we have a high-confidence way to reproduce the issue? Current-main source establishes the sequential delay, and the supplied controlled observations exercise stalled response bodies; no target code was run during this review. Is this the best way to solve the issue? Sharing the existing poll interval with optional detail fixes the scheduling cause without changing backend provisioning, primary deadlines, quota wording or authorization. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 381289d339c1. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReviewed October 17, 2026, 2:47 AM ET / 06:47 UTC (Revision 3). |
|
@clawsweeper re-review The Verification section now has the previously missing native screenshots and recording. I retrieved the served bytes, matched the capture hashes, and decoded the media. The captions state which behavior is demonstrated. This is new visual evidence on the same reviewed commit, not a CI rerun or a score request. |
|
🦞👀 Re-review progress:
|
|
@clawsweeper re-review I addressed the specific flow-documentation finding in 25c81ea. The guide now says the optional deployment read shares the interval between status reads, leaving the page stops further polls, and the accepted provisioning job continues. Independent review also caught and corrected an overbroad failure-recovery sentence before publication. The guide is 2,483 visible words; documentation checks validated 258 pages and 4,141 links, and the spec checks passed. Only the guide changed since the native UI evidence you reviewed. |
|
🦞👀 Re-review progress:
|
Create Agent waits one second between provisioning reads. It can use that time to show a useful deployment detail, such as a full Namespace Pod quota, but a slow detail response should not postpone the next provisioning read. The same timer now ends the optional read and releases the next poll. If you leave Create Agent, the old page stops polling; the provisioning job continues. The provisioning request, its timeout, and the quota message are unchanged.
Fixes #2681. This corrects when the Console observes provisioning; it does not make provisioning itself faster or explain the OpenShell timeout in #2658.
Verification
keyboard-poll-continues-then-quota.mp4