[freeqaz-openai]

Ten worker starts repeated the gateway driver and 50 ms convergence setting already provided by startWithGateway. They now pass just the Compute behavior each test needs. The case that also records worker events keeps its explicit setup.

All 36 tests in the file passed before and after with PostgreSQL 18.6. In a separate copy, making the first withdrawal report revoked instead of pending failed the existing retry assertion: one attempt instead of two. These are worker tests with a simulated gateway, not a live credential operation.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs maintainer review before merge.

What this changes

This PR replaces ten repeated worker configurations with the existing gateway setup helper.

Example: A credential-withdrawal test starts its worker with a 50 ms convergence timeout.

• Before: The test repeats the timeout and gateway Driver configuration.
• After: startWithGateway supplies the identical configuration.

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	Focused, correct test maintenance supported by PostgreSQL harness validation; evidence does not exercise a live gateway and makes no such claim.
Proof confidence	🦐 gold shrimp (3/6)	This collaborator-authored test-only refactor changes no shipped behavior; PostgreSQL CI supports fixture equivalence, and simulated gateway results are explicitly distinguished from live credential operations.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Test only · Worth it: Yes · Fix scope: Complete
Reason: The collaborator-authored direction reduces duplicated fixture configuration using its established owner without changing product contracts or test expectations.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: it is a focused, behavior-preserving test cleanup with no actionable findings, and repository policy reserves closure for maintainer triage.

Priority: P3
Reviewed head: 632d78b53aab13f850685c66fa1988b92ac784ca

Before merge

None.

Findings

None.

Agent review details

How this fits together

PostgreSQL integration fixtures start the real controller worker with simulated Compute and gateway Drivers, then inspect durable work, authorization outcomes, and withdrawal state.

flowchart LR
  A[Withdrawal test] --> B[Existing gateway setup helper]
  B --> C[Worker fixture]
  C --> D[Controller worker]
  D --> E[PostgreSQL state]
  D --> F[Simulated Compute Driver]

Loading

Technical review

Best possible solution:

Reuse the existing helper while retaining each scenario’s Compute behavior and the event-recording case’s explicit options.

Do we have a high-confidence way to reproduce the issue?

No product bug is claimed; source inspection verifies that the helper supplies the exact options removed from each call site.

Is this the best way to solve the issue?

The existing helper is the smallest complete owner for this repeated setup, and the diff preserves scenarios, assertions, and special event capture.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against ee9391867036.

Provenance checked

• Credential-withdrawal worker setup keeps the original intent (refactor(credentials): share withdrawal recovery checks and outage test setup #1840: Share repeated gateway-outage and worker setup while preserving test behavior; the later file split carried these helpers into the credential-source suite.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

• Exact introduced change: All ten replacements preserve their Compute overrides and replace the same two worker options; no assertions or production files change. (tests/integration/postgres-worker-agent-revision-credential-sources.test.mjs:99, 632d78b53aab)
• Equivalent existing owner: startWithGateway forwards Compute unchanged and supplies convergenceTimeoutMs: 50 and transformDrivers: withCredentialGateway; the event-recording case retains its explicit emit option. (tests/integration/postgres-worker-agent-revision-credential-sources.test.mjs:259, 632d78b53aab)
• Prior design intent: refactor(credentials): share withdrawal recovery checks and outage test setup #1840 introduced startWithGateway to share withdrawal test setup; test(worker): harden the convergence deadline tests and split the revision file #2298 subsequently moved the credential-source cases and helpers together. This PR extends that established approach. Some deeper local historical blob reads were unavailable; the merged PR descriptions supplied the original rationale. (tests/integration/postgres-worker-agent-revision-credential-sources.test.mjs, 0aac2a76a683)
• Reviewed-head validation: PostgreSQL Application and CI Required succeeded for head 632d78b in https://github.com/openclaw/openclaw-enterprise/actions/runs/39073063309. The PR reports 36 tests passing before and after, plus a mutation that breaks the existing retry assertion; these remain test-harness claims. (scripts/ci/test-suites/postgres-application.json:14, 632d78b53aab)
• Current-main comparison and discussion: Fetched main retains the repeated setups; its intervening changes do not touch this file. Both discussion comments are review-status notices, with no additional direction or proof. (tests/integration/postgres-worker-agent-revision-credential-sources.test.mjs, ee9391867036)

Likely related people:

• Free Wortley: Raw commit f890b9d adds tests/integration/postgres-worker-agent-revision-credential-sources.test.mjs:260 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: f890b9d48ddb; files: tests/integration/postgres-worker-agent-revision-credential-sources.test.mjs)

Review metrics

Metric	Value	Why it matters
Scope	Production +0/-0; tests +104/-134	Reuses an existing helper at ten call sites, removing 30 net lines without adding machinery or assertions.

Labels

Label changes:

• add P3: Low-risk test maintenance with no user-visible behavior change.
• add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

• P3: Low-risk test maintenance with no user-visible behavior change.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 17, 2026, 6:09 PM ET / 22:09 UTC.