Repository navigation
Conversation
Under 760 px each Agent renders as a stacked row: name and ID first, then each cell beside its column name (data-label), with no sideways scroll. The deployment cell keeps two lines reserved so a landing read does not grow the row (finding 1488). Revision IDs in Current version are mono text-colour links instead of accent links. UX plan C5.
Under 520 px each column name sits above its value so values keep the row's full width; 521-760 px keeps them side by side. The browser test covers 390, 360, 600 and 1440: no sideways scroll, every column name shown, IDs break only after a hyphen or underscore, row heights do not change when the deployment reads land, and the name opens the Agent.
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Explicit table roles so a browser that drops them on display changes keeps the table; the cell label is not read twice (alt text ""); the ID gets scale spacing and the full row width on a phone; the dead 760 px cell padding rule goes; the revision link class is added, not assigned. The test now requires the IDs to wrap at 360 and pins the revision ID style.
|
Codex review: needs maintainer review before merge. What this changesThe Agents list becomes labelled, stacked rows below 761 px, and current-version links receive a quieter monospace style. Example: View Research assistant in the Agents list at 390 px.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR provides a useful mobile layout improvement that current main does not implement; no definite code defect was found. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe console list renderer receives authorized Agent summaries and asynchronous deployment reads, then produces navigable rows styled by the shared console stylesheet. flowchart TB
A[Authorized Agent summaries] --> C[Agents list renderer]
B[Deployment reads] --> C
C --> D[Table cells and navigation links]
D --> E[Responsive console CSS]
E --> F[Desktop table or stacked mobile rows]
Technical reviewBest possible solution: Retain the responsive presentation within the existing list renderer and stylesheet, preserving navigation and stable deployment-row heights. Do we have a high-confidence way to reproduce the issue? Current-main source explains the horizontal table overflow, and the supplied before images show it at phone widths; no target code or tests were run during this read-only review. Is this the best way to solve the issue? The change uses the existing renderer and responsive stylesheet, preserves revision links, and carries forward the deployment-height invariant without adding another rendering path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 39dead53499d. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 18, 2026, 5:48 PM ET / 21:48 UTC. |
Problem
UX plan C5. On a phone the Agents list is a 5-column table inside a sideways-scrolling
.table-scroll: the "Latest deployment" column reserves 14 rem, so 390 px shows about 2.5 columns and the page otherwise does not scroll sideways. IDs broke after every character (agt_13a0 / 7eb7- / f515-) because the ID column shrank to itsoverflow-wrap: anywheremin-content. Revision IDs in "Current version" were accent-coloured, the same red as errors and the primary button (audit 2.2, 2.7; design language P6).Change
agents/list.mjs: cells 2-5 carrydata-labelwith their column name; the Current version link getsagent-revision-link. The table parts get explicittable/rowgroup/row/columnheader/cellroles, because some browsers drop table semantics when a table part's CSSdisplaychanges. No copy changes.console.css, under 760 px: the table, its body and rows become stacked rows. Each row shows the Agent name and ID first, then each cell with its column name (td[data-label]::before). The header row is visually hidden but stays in the accessibility tree, so screen readers still get table, row and column header semantics; the visible labels carry empty alt text (content: attr(data-label) / "") so a cell is not announced with its column name twice. Between 521 and 760 px each name sits beside its value (subgrid, so the names line up). At 520 px and under each name sits above its value, so values keep the row's full width. IDs wrap at hyphens because the cell is a full-width block;overflow-wrap: anywhereis only the fallback.--space-2above it and the row's full width; the now-dead 760 px cell padding rule is removed.Verification
tests/browser/console-agents-list-return.test.mjs(already in checks-browser-2), "On a phone the Agents list stacks each row, fits the screen and still opens the Agent". It uses 12 Agents with 60-character names (half with a current version) at 390, 360, 600 and 1440, and asserts:scrollWidth <= clientWidthfor the page and.table-scroll), and no cell outside the table;-or_, and at 360 every ID does wrap (so the check is never vacuous);content, or the reserved deployment row under 520 px, fail it. Dropping only theclip-pathof the hidden header survives, since the header is still 1px with overflow hidden.console-agents-list-return,console-agents,console-agents-2(including the finding 1488 "does not move" test, shift 0 at 1280 and 390),console-retained-revalidation,consoleandconsole-refocus-focuspassed (189/189). On the head merged with main (fix(console): first-run and not-ready Namespace guidance #2867, refactor(console): replace raw colour and shadow literals with tokens #2873):console-agents-list-return,console-agents,console-agents-2,console-namespace-not-readyandconsole-retained-revalidationpassed (142/142).classList.addinstead of assigningclassName, non-vacuous ID-wrap check, revision style check. Not applied (optional): hover on touch devices (pre-existing), larger tap targets for inline links.Before/after (Storybook preview frames, main
39dead534vs this head; media commit5aabfab1556fb332202d08f8343fc46ea987f12c, removed in the next commit):Phone recording at 390 (webm): scroll the stacked list; a sideways scroll attempt moves nothing (list and page scrollLeft stay 0); tapping "Research assistant" opens that Agent
At 1440 the Populated story is sha256-identical before and after. In the failed-deployment story only the Current version revision ID changes (mono, text colour). At 600/390/360 main scrolls sideways (
.table-scrollscrollWidth > clientWidth) and this PR does not.Storybook stories: Pages/Agents › Populated, Pages/Agents › Latest Deployment Failed.
Open PRs (3-way merge, conflict files/hunks with origin/main vs with this head):
No new conflict hunk. #2524 already conflicts with main in
list.mjs(it movesrenderAgentListout); this change edits inside that same region and adds no hunk.Risks
Low. CSS under 760 px plus
data-labelattributes. On phones the row layout changes (intended). At 761-1100 px the table and its sideways scroll are unchanged. Screen-reader table semantics depend on the browser keeping table roles fordisplay: block/gridtable parts. Chromium keeps them (asserted in the test). Older Safari versions are known to drop them; that is a known trade-off of this pattern.