[freeqaz]

Problem

Create Agent has no busy state while its request runs (finding 1961, the remainder of finding 1927). The form's pending flag is shared with other controls' requests: Check credential registration, Remove failed credential registration, Reload repository choices and Retry provisioning request. Marking Create busy from pending would make it look busy while one of those runs, so #2896 left Create disabled but not busy: it showed the not-allowed cursor, and assistive technology heard "unavailable" instead of "working".

Change

• agents/create.mjs: Create keeps its own in-flight flag, createPending. It is set where the submit handler starts its request.
  • updateControls() writes aria-busy on Create from that flag, so the B4 rule shows the progress cursor.
  • endCreate() clears the flag and the attribute on every way the request ends:
    • a preflight refusal;
    • the main request's finally, which covers success, refusal, an uncertain outcome and a provisioning hand-off;
    • a navigation away. The view it leaves may still show as an inert preview, so the attribute is cleared even when the view is no longer current.
  • The other controls still set only pending. They disable Create but do not mark it busy.
• Storybook: new story Pages / Create Agent / Create pending. The provision and validate requests are held, so Create shows aria-busy="true" with the progress pointer.

Verification

• Two new tests in tests/browser/console-button-hierarchy.test.mjs (already mapped to checks-browser-2.json). Both fail on main:

  • Create Agent shows busy while its request runs and clears it on refusal, success and navigation away. The preflight is held and then refused, the Agent POST is held and then succeeds, and the preflight is held while the page goes to ← Agents. Each time, the button reads aria-busy="true" with the progress cursor while the request is held, and "false" afterwards. For success and navigation, the check is on the button the page left.
  • Create Agent is busy only for its own request, not a recovery control's. The test uses a Credential Gateway installation. A lost registration (503) leaves Create disabled but not busy. While Check credential registration's read is held, Create is disabled with aria-busy="false" and no progress cursor. A refused registration (400) ends the busy state.

• Mutants, run one at a time:

  mutant	result
  main's create.mjs	both tests fail
  aria-busy from the shared pending	killed by the recovery-control test
  no endCreate() in the main finally	killed
  no endCreate() in the preflight catch	killed
  no endCreate() on the "view no longer current after a successful preflight" path	survives

  The survivor is a defensive path. Leaving the page aborts the preflight, so the browser ends up in the catch, which the navigation case covers. The path is reached only when a response and a navigation land in the same tick.

• console-button-hierarchy.test.mjs ran 20/20 at 2 CPUs (taskset -c 6-7).

• Prettier and eslint are clean on the touched files.

• The Storybook story was checked in Chromium at 1440 and 390: Create reads aria-busy="true", disabled, cursor: progress.

• Native browser evidence, from the real Console with a local test fixture, captured on c440849c. All production code is byte-identical at 4e542698; that commit changed only the test and the story.

  • The recording shows ready, then pending, then a controlled refusal.
  • Measured: aria-busy false → true → false, and cursor pointer → progress → pointer.

  

  ready-pending-refused.mp4

• Hosted Console Browser 2 tested the exact 4e542698 tree: 362 passed, including both new cases; none skipped.

• Open PRs: I ran a 3-way git merge-tree against every open PR touching the console, create.mjs or the Storybook scenarios (fix(console): Agents list wraps long names on wide screens; phone sheets stay above the keyboard #2893, test(console): kill surviving mutants in the harness lock, JSON scan and recovery card #2892, fix(console): keep a focused workspace caret on reread and quiet plugin live regions #2860, fix(console): let the create preflight carry any configuration both creates accept #2833, feat: add per-agent sandbox network policies and denial review #2599, feat(console): show the authorized native Gateway people roster #2596, feat(console): stop and delete Agents from the Agents list #2524, Draft implementation: managed outbound HTTPS for dedicated Gateways #2518, fix(console): distinguish stale runtime status from loss of access #2505, fix(console): keep followed logs steady and report the first output #2502, Add OCE policy simulation and tester for network and plugin actions #2445, fix: preserve native plugin permissions across Harness selection and admission #2258, fix(console): grant Agent access to accepted Configuration Secrets #2255, Support custom Installation profiles and readable Preset starters #2253, feat(auth): sign people in to occ with a device code (rfc-0019) #1619, feat: assign configured OpenClaw roles to Agent users #906, docs(specs): propose rfc-0019 for repository options without a repository driver #878, feat: add Agent workload tags #115). Each PR's conflict-hunk count is the same against this head as against main. This branch adds no new conflict hunk.

Risks

Low. It changes only Create's busy attribute and adds one story. Create's disabled logic and request flow are unchanged.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[freeqaz-openai]

Free's clanker here. The navigation-test gap is fixed in 4e542698. Moving the assertion before the held response is released was sufficient; no new timeout or production change needed.

Both new browser tests passed unchanged. When I deliberately made validation outlive the page, the old test still passed, but this head failed at the intended assertion (line 413), at 10 seconds, before the client's 15-second timeout could make it pass accidentally. That proves browser-side abandonment, not server-side cancellation. I corrected my private checkout's workspace links before these runs. Hosted Browser 2 passed all 362 cases on a tested tree identical to this head.

Pending-state screenshot · Six-second ready → pending → refused recording. Real Console, local browser fixture, controlled refusal; production bytes are unchanged since capture at c440849c. Measured busy false → true → false, cursor pointer → progress → pointer. The recording does not claim to capture the OS pointer or screen-reader speech. I added both native attachments to Verification and downloaded and byte-verified them; a subsequent body edit removed those links, so please preserve them when finalizing the description. I will not overwrite concurrent edits.

No further source change requested from this review; ClawSweeper and the ordinary review protections still apply.

[clawsweeper]

Codex review: needs maintainer review before merge.

What this changes

Create Agent now reports busy only while its own submission runs and clears that state when the request ends.

Example: A user selects Create Agent while its validation request is delayed.

• Before: Create is disabled without aria-busy and shows the not-allowed cursor.
• After: Create sets aria-busy="true" and shows the progress cursor, then clears busy after refusal, completion, or navigation.

Review scores

Measure	Result	What it means
Overall readiness	🦞 diamond lobster (5/6)	A focused accessibility repair with supplied browser evidence, distinct regression scenarios, successful exact-head CI, and no identified defect.
Proof confidence	🦞 diamond lobster (5/6) ✨ media proof bonus	Sufficient (screenshot): The supplied real Console browser-fixture capture exercises Create with a controlled refusal at c440849, whose production source matches the reviewed head; its native screenshot, linked recording, and measured busy/cursor transitions establish the scoped UI behavior. Video decoding was locally blocked by reviewer infrastructure, not missing contributor evidence; backend provisioning and screen-reader speech are not claimed.
Patch quality	🦞 diamond lobster (5/6)	No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: While Create Agent is working, its disabled button conveys unavailability rather than an operation in progress.
Reason: The maintainer-authored change implements the previously recorded accessibility direction with a small presentation-only repair.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: it completes an intentional accessibility follow-up with a focused implementation and meaningful regression coverage; no actionable defect was found.

Priority: P3
Reviewed head: 4e54269885d277ee47859abba7bd1d59e0b5fcdd

Before merge

None.

Findings

None.

Agent review details

How this fits together

The console creation form submits validation and resource requests through the existing API client; its local presentation state determines the Create button's accessibility attributes and cursor.

flowchart LR
  User[Console user] --> Form[Create Agent form]
  Form --> Request[Existing API client]
  Request --> API[Validation and creation APIs]
  Form --> State[Create busy state]
  State --> Button[Button accessibility and cursor]

Loading

Technical review

Best possible solution:

Use the existing creation form's submission lifecycle to maintain Create-specific busy presentation, as this PR does.

Do we have a high-confidence way to reproduce the issue?

Current main disables Create through shared pending state without assigning its own aria-busy value; the existing CSS requires aria-busy="true" for the progress cursor, and the supplied regression comparison reports both added tests fail on main.

Is this the best way to solve the issue?

The separate flag is appropriate because shared pending also represents other controls, and cleanup covers both preflight and mutation lifecycles without adding a parallel request owner.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 90c63bf8e7c2.

Provenance checked

• Create button busy semantics keeps the original intent (feat(console): button hierarchy classes #2896: Create was intentionally excluded from busy styling because its pending state was shared with unrelated recovery controls.)
• Creation lifecycle and preflight cleanup keeps the original intent (835b1cc: The form uses pending state to disable controls during creation; later preflight validation refuses invalid plans before saving resources.)

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

• Focused production change: The introduced patch adds a separate Create flag, writes aria-busy from it, and clears it on preflight failure, stale-view return, and the main finally path without changing request payloads or disabled conditions. (apps/controller/src/console/agents/create.mjs:2044, 4e54269885d2)
• Recorded product intent: The merged feat(console): button hierarchy classes #2896 explicitly deferred Create's busy state because its shared pending flag also covers recovery requests; this PR preserves that distinction. (apps/controller/src/console/agents/create.mjs:1234, 90c63bf8e7c2)
• Distinct browser regression scenarios: The added cases exercise real console controls through held requests, covering refusal, successful creation, navigation before the response is released, uncertain registration, and a separate recovery request that must not mark Create busy. (tests/browser/console-button-hierarchy.test.mjs:368, 4e54269885d2)
• Exact-head hosted validation: https://github.com/openclaw/openclaw-enterprise/actions/runs/39190340428 completed successfully for the reviewed head, including Console Browser 2; the browser file is registered in that suite. (scripts/ci/test-suites/checks-browser-2.json:26, 4e54269885d2)
• Supplied browser evidence: Inspected the native pending-state screenshot. The body and fix(console): Create Agent shows its own busy state #2898 (review) supply the recording and measured false→true→false busy transition. Production source is unchanged since capture at c440849. Local video preparation failed with 'ffprobe failed: spawnSync ffprobe ENOENT'; browser fallback failed during Chromium Crashpad startup after scratch writes were rejected as read-only. These are reviewer infrastructure limits. (4e54269885d2)
• Policy and history inspection: Read the complete root AGENTS.md; no nested AGENTS.md governs the changed paths, and neither maintainer notes nor pr-simplify exists here. Feature history includes original creation, provider setup, provisioning, and recent accessibility work. Follow-history traversal eventually encountered an unavailable promised object; concrete owner lines and relevant commits remained readable. The checkout stayed clean. (AGENTS.md:1, 4e54269885d2)

Likely related people:

• kevinlin-openai: Raw commit 835b1cc adds apps/controller/src/console/agents/create.mjs:143 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 835b1cc9b775; files: apps/controller/src/console/agents/create.mjs)

Review metrics

Metric	Value	Why it matters
Change distribution	Production +14/-0; browser tests +202/-1; Storybook +12/-0	The larger test change protects distinct completion and recovery-control behaviors while reusing existing request-holding and browser fixtures.

Labels

Label changes:

• add P3: This improves accessibility and cursor feedback during an otherwise functioning creation workflow.
• add proof: sufficient: Contributor real behavior proof is sufficient.
• add proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence.
• add rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

• P3: This improves accessibility and cursor feedback during an otherwise functioning creation workflow.
• rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
• proof: sufficient: Contributor real behavior proof is sufficient.
• proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 18, 2026, 10:59 PM ET / October 19, 2026, 02:59 UTC.