[freeqaz]

Problem

The Agents list marks a name with a run of 21 or more characters that cannot wrap, so the name breaks anywhere inside the width of its ID instead of setting the table's width (finding 1955, #2906). Measured in Chromium, the rule disagreed with the browser both ways (finding 1982):

• Missed: a hyphen, dash, soft hyphen or wide space followed by closing punctuation (. , : ; ) ] } / ! ’ ” », a joiner or a word joiner) is not a break, but the rule treated it as one. "abc-.5" repeated stayed unmarked and pushed the table to 1949 px inside a 1101 px scroller in Storybook.
• Over-marked: Chromium does break "1000-1001" after the hyphen, so the digit-group case from fix(console): badge tones, danger tone and long-name wrapping #2906 (finding 1971) and its test row were wrong. Combining marks, CJK ideographs, kana, Hangul and emoji names were also marked. Over-marking only boxes the name at 310 px, so those were harmless.

Change

• apps/controller/src/console/agents/list.mjs: the rule is built from named parts, each one a measured Chromium break point:
  • A hyphen-minus holds the next character before closing punctuation, $, an Arabic-Indic digit, or a hyphen, figure dash or en dash. It does not hold another hyphen-minus.
  • A hyphen-minus that no letter or digit precedes holds a digit (-5). Between digits it breaks (1000-1001), so the digit-group case from fix(console): badge tones, danger tone and long-name wrapping #2906 is removed.
  • A wide space, soft hyphen or dash holds closing punctuation, a quote or a vertical bar. A combining mark between them does not change that.
  • A hyphen or dash, an em dash included, holds a following hyphen or dash other than an em dash (LB21).
  • A hyphen, figure dash or en dash that starts a word (at the start or after a space) holds a letter (LB20a). A hyphen-minus does not.
  • The hyphen or wide space a line breaks after stays on that line, so 20 letters plus a trailing hyphen are a run of 21.
  • The em-dash-run case stays: the probe confirms that 40 em dashes never break.
  • Any character but a space or an em dash holds a following word joiner or zero-width joiner (LB11, LB9), so ideographs joined by word joiners are one run (review bot P2). What follows a joiner keeps its own rules, so separate emoji family sequences still break between them.
  • Combining marks count with their letter. Ideographs, kana, Hangul syllables and emoji end a run. Thai and other dictionary-broken scripts still count per character. That can only over-mark, so there is no script-aware segmenter.
• tests/browser/console-agents-list-return.test.mjs: one row per measured case. The digit-group row now expects unmarked. Each row is checked two ways: against the rule, and against the browser's own layout. The test measures the longest run the browser keeps on one line in the link's font, and it must be 21 or more exactly when the name is marked. The 1440 px table must still not scroll sideways.
• Storybook (Pages/Agents): the "Long name of digit groups" description no longer claims a non-break. A new "Long name with punctuation after hyphens" story shows a name that stays marked.

UX plan finding fix (bughunt-126, finding 1982).

Verification

• Probe (a local headless-Chromium script): 21 break characters × 119 following characters (2499 pairs), plus named cases (scripts, emoji, combining marks, word-initial hyphens and dashes, run thresholds, Arabic-Indic and full-width digits). On main (34 names): 304 pairs and 4 names missed; 11 pairs and 14 names over-marked. With this change (66 names, joiner cases included): none missed; only Thai and the Hebrew maqaf are over-marked (accepted).
• The new test fails on main at its first row ("1000-1001-…" marked).
• Mutants, each killed by the test (16):
  • the hyphen-minus closing-punctuation rule removed
  • the wide space and dash closing-punctuation rule removed
  • the word-initial dash rule removed
  • the word-initial hyphen-minus before a digit rule removed
  • the trailing break character not counted
  • marks counted per code point
  • ideographs counted
  • the digit premise restored
  • the Arabic-Indic digit rule removed
  • the em-dash run removed
  • the dash-before-dash rule removed
  • U+201D dropped from closing punctuation
  • hyphen-minus pairs held
  • word-initial hyphen-minus before a letter held
  • the joiner rule removed (joined ideographs unmarked)
  • the joiner rule made two-sided (emoji family sequences over-marked)
• The rule takes 0.03 ms or less on adversarial 200-character names (runs of hyphens, hyphen pairs, a letter with 199 marks, and others).
• tests/browser/console-agents-list-return.test.mjs: 18/18. On the final head, the whole file was pinned 20/20 at 2 CPUs (taskset 2,3).
• eslint and prettier are clean on the touched files.
• Open-PR conflicts (git merge-tree, conflict hunks main → this head): fix(console): finish moving errors and notices to the status block #2912 0→0, fix(console): let the create preflight carry any configuration both creates accept #2833 0→0, feat(console): show the authorized native Gateway people roster #2596 0→0, feat(console): stop and delete Agents from the Agents list #2524 4→4, feat: add per-agent sandbox network policies and denial review #2599 33→33, RFC and implementation: managed outbound HTTPS for dedicated Gateways #2518 11→11, fix(console): distinguish stale runtime status from loss of access #2505 2→2, fix(console): keep followed logs steady and report the first output #2502 6→6, Add OCE policy simulation and tester for network and plugin actions #2445 4→4, fix: preserve native plugin permissions across Harness selection and admission #2258 3→3, fix(console): grant Agent access to accepted Configuration Secrets #2255 5→5, Support custom Installation profiles and readable Preset starters #2253 3→3, feat(auth): sign people in to occ with a device code (rfc-0019) #1619 17→17, feat: assign configured OpenClaw roles to Agent users #906 6→6, docs(specs): propose rfc-0019 for repository options without a repository driver #878 2→2. No new hunks.

Media (Storybook, Pages/Agents):

• Final revision (commit b5cf316, removed before the squash): walkthrough at 1440 and 1024, and the "after" screenshots below. They are byte-identical to the first capture (091ff87), because the later rule fixes do not change these two names.
• Before (main), from 091ff87.

	Before (main)	After (final revision)
Long name with punctuation after hyphens, 1440
Long name with punctuation after hyphens, 390
Long name of digit groups, 1440
Long name of digit groups, 390

At 1440 the punctuation name scrolled the table sideways on main (scrollWidth 1949 in a 1101 px scroller) and fits after (1101/1101). The digit-group name is no longer boxed: it wraps at its hyphens. The 390 layouts are unchanged (stacked rows break names anywhere at phone width). Stories: Pages/Agents "Long name with punctuation after hyphens" (new) and "Long name of digit groups".

Risks

• A name of digit groups joined by hyphens (or any other long hyphenated name) now wraps at its hyphens, like "nightly-build-…" always did, instead of being boxed at 310 px. Its column can be wider, and the other columns narrow to fit. The table still fits at 1440 px.
• The rule is a measured subset of UAX fix: recover production cutovers and protect email sign-in #14, not a segmenter. Over-marking (Thai, the Hebrew maqaf) still shows the whole name in a narrower box, which is harmless. No measured case is missed; names outside the probe could still be, and would need contrived punctuation.
• The review bot's P2 (joined ideographs lost the mark) is fixed and pinned by a row. An internal review approved with nits. All of them are applied: hyphen-minus pairs, the word-initial rules, marks before closing punctuation, the trailing break character, the U+201D row, and hanging spaces in the test's count.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[freeqaz-openai]

@freeqaz make sure you're waiting for clawsweeper feedback before landing PRs.

[clawsweeper]

Codex review: needs maintainer review before merge.

What this changes

This PR refines long Agent name classification and adds browser and Storybook coverage for Chromium line breaks.

Example: An Agent has a 200-character name built from repeated abc-.5 groups at a 1440 px viewport.

• Before: The name widens the table to 1949 px inside a 1101 px scroller, hiding other columns.
• After: The name wraps within the existing bound and all five columns fit.

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	The inspected visual result and browser coverage support the focused fix; the repository's required UI attachment gate remains incomplete.
Proof confidence	🐚 platinum hermit (4/6)	Real behavior proof is not required for maintainer- or bot-authored pull requests.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: Some long Agent names push the other Agents table columns off-screen.
Reason: The demonstrated failure is user-visible, the maintainer-authored direction is established, and the change stays within the existing layout mechanism.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: it fixes a demonstrated layout bug still present on main, addresses the prior joined-ideograph finding, and introduces no definite code defect found in this review.

Priority: P2
Reviewed head: 29417329825ae0878e9fb87dc069035ea28fd634

Before merge

None.

Findings

None.

Tests

• Missing end-to-end proof: Attach the existing screenshots and walkthrough natively to GitHub to satisfy the repository's UI evidence gate.

Agent review details

How this fits together

The console Agents list receives Agent names from API responses, classifies unbreakable runs, and applies an existing CSS class that bounds desktop name links.

flowchart LR
  A[Agent API response] --> B[Agents list renderer]
  B --> C[Unbroken run classifier]
  C --> D[Name link class]
  D --> E[Existing console CSS]
  E --> F[Browser table layout]

Loading

Technical review

Best possible solution:

Retain the focused correction within the existing classifier and bounded-link CSS owner.

Do we have a high-confidence way to reproduce the issue?

Current main's classifier and the supplied before screenshot establish the punctuation-name failure; no target code or tests were run during this review.

Is this the best way to solve the issue?

The change preserves the existing layout owner and threshold while correcting measured break rules, with independent browser-layout assertions rather than a copied classifier oracle.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 5963327b74b6.

Provenance checked

• Long-name classifier and browser expectations changes intended behavior with a stated reason (a25e598: Keep hyphenated digit groups and dash runs from widening the table; the earlier PR stated a digit-break premise contradicted by the supplied Chromium measurements.)
• Selective bounded-name layout keeps the original intent (d717962: Bound only unusually long unbreakable names because applying a column-wide wrapping rule changed ordinary table widths and word wrapping.)
• Digit-group Storybook description changes intended behavior with a stated reason (a25e598: Document the previously assumed non-break after a hyphen before a digit.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

• Introduced change: The pinned introduced diff changes only the classifier, its browser coverage, and matching Storybook scenarios. (apps/controller/src/console/agents/list.mjs:268, 29417329825a)
• Current main still needs the correction: Fetched main retains the earlier regex, including its digit-group premise and missing punctuation holds. (apps/controller/src/console/agents/list.mjs:267, 5963327b74b6)
• Prior finding addressed: Comparison with the previously reviewed head shows a joiner-aware alternative and regression rows for joined ideographs and separate emoji family sequences. (apps/controller/src/console/agents/list.mjs:287, 29417329825a)
• Visual result inspected: Downloaded before and after screenshots show the punctuation name changing from an overflowing row to a wrapped name with every column visible; the media revision has identical console and Storybook source to the reviewed head. (scripts/console-storybook/public/scenarios.mjs:3715, 29417329825a)
• UI evidence policy: Root policy requires screenshots and a short video as native GitHub attachments before merging UI changes; this PR currently links committed media instead. (AGENTS.md, 29417329825a)
• Feature provenance: The original bounded-name classifier was introduced by fix(console): Agents list wraps long names on wide screens; phone sheets stay above the keyboard #2893 and extended by fix(console): badge tones, danger tone and long-name wrapping #2906 to preserve ordinary table layout. (apps/controller/src/console/agents/list.mjs:259, d7179620ea35)

Likely related people:

• Free Wortley: Raw commit d717962 adds apps/controller/src/console/agents/list.mjs:259 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: d7179620ea35; files: apps/controller/src/console/agents/list.mjs)

Review metrics

Metric	Value	Why it matters
Production and regression coverage	Production +35/-8 lines; browser tests +93/-23 lines	The additional coverage checks distinct Unicode break cases against browser layout and verifies the resulting table width.

Labels

Label changes:

• add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
• remove rating: 🦪 silver shellfish: Current PR rating is rating: 🦐 gold shrimp, so this older rating label is no longer current.
• remove status: ⏳ waiting on author: Current PR status label is status: 👀 ready for maintainer look.

Label justifications:

• P2: Certain valid long names hide desktop table columns; this is a bounded console layout bug.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

• Upload the existing screenshots and walkthrough as native GitHub attachments in Verification.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (1 earlier review cycle)

• reviewed 2026-10-19T07:56:00.236Z sha 682e711 :: needs changes before merge. :: [P2] Preserve no-break joins before excluding ideographic characters

Reviewed October 19, 2026, 5:00 AM ET / 09:00 UTC (Revision 2).

[freeqaz]

@clawsweeper re-review

[clawsweeper]

🦞👀
Exact review queued.

Re-review progress:

• State: Complete
• Detail: The durable review result and its route handoff completed.
• Run: https://github.com/openclaw/clawsweeper/actions/runs/39227119400
• Updated: 2026-10-19T09:03:00.230Z