[freeqaz-openai]

Keep the single browser round trip from #2947, but select links rather than every <a> element. An anchor can lose its href and still have the same text, styling, and width; the batched test on main missed exactly that change.

I ran the owning Agents-list browser test at 1024 and 1440 pixels. With the UI untouched, the revised test passed at both widths. When I removed only the first Agent name’s href in the test fixture, the test on main still passed; the revised assertion failed at each width, finding zero matching links instead of one.

This changes only the test. It checks link role and displayed text, not the destination URL, and it does not imply that an Agent link is currently broken in the product.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs maintainer review before merge.

What this changes

This PR checks Agent names by link role while preserving batched browser measurements.

Example: Remove the first Agent name’s href at viewport widths of 1024 and 1440 pixels.

• Before: The anchor still enters the measurement batch, so the missing link can pass unnoticed.
• After: The name has no matching link in the batch, and the assertion fails.

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	The focused patch is source-supported and has no findings; validation consists of reported native-browser mutation runs, with exact-head CI still queued.
Proof confidence	🦐 gold shrimp (3/6)	This maintainer-authored test-only PR is outside the ordinary live-behavior proof gate; its body reports browser and mutation runs at both widths, without linked execution artifacts.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Test only · Worth it: Yes · Fix scope: Complete
User problem: A future Agent-name navigation regression could escape the long-name browser test.
Reason: The maintainer-authored direction restores a previously enforced behavior with a minimal extension of existing coverage.

Merge readiness

✅ Ready for maintainer review

Keep open: this maintainer-authored PR restores meaningful regression coverage with a focused test-only change and no actionable findings.

Priority: P3
Reviewed head: 6a805e0854939b551066910ee6251fe15bb9c625

Before merge

None.

Findings

None.

Agent review details

How this fits together

The console browser suite opens the served Agents list through the existing application fixture and compares rendered name semantics, wrapping, and widths with expected cases.

flowchart LR
  A[Application fixture] --> B[Served Agents list]
  B --> C[Chromium browser]
  C --> D[Link role selection]
  D --> E[Batched measurements]
  E --> F[Name and layout assertions]

Loading

Technical review

Best possible solution:

Retain the focused role-based batch selection and existing layout assertions.

Do we have a high-confidence way to reproduce the issue?

Source inspection confirms that main includes anchors without href in its measurement batch; the author reports the corresponding mutation comparison, which was not independently executed during this review.

Is this the best way to solve the issue?

The patch restores the earlier semantic invariant through the existing browser test while preserving batching and adding no production machinery.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 22283f690f8a.

Provenance checked

• Batched long-name browser measurements keeps the original intent (22283f6: The preceding consolidation reduced repeated browser lookups while intending to preserve assertions.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

• Focused introduced change: The pinned diff changes only link selection, the equivalent measurement-box placement, and the assertion message; all wrapping and width assertions remain. (tests/browser/console-agents-list-return.test.mjs:1084, 6a805e085493)
• Original coverage and consolidation intent: The earlier test selected each name with getByRole("link"). test(console): consolidate the console browser tests added since #2903 #2947 consolidated measurements to reduce browser round trips; this PR preserves that optimization while restoring the semantic check. (tests/browser/console-agents-list-return.test.mjs, 61ec42252eb8)
• Production owner: agentNameLink constructs a navigation link and conditionally applies the unbroken-name class; the patch changes no production rendering or destination. (apps/controller/src/console/agents/list.mjs:319, 22283f690f8a)
• Reported mutation validation: The full PR body reports normal passes at both widths and a first-name href mutation that passes the main assertion but fails the revised assertion; it explicitly disclaims a current broken product link. (6a805e085493)
• Validation state: The exact head has one successful CodeQL check and thirteen queued checks, including Console Browser 2; no failing check is reported. (6a805e085493)
• Policy and history boundary: The complete root AGENTS.md was read; no nested test instructions, maintainer notes directory, or pr-simplify skill were found. Relevant recent history and original measurement code were readable; follow-history eventually stopped on an unavailable older object. No tests, helpers, or second reviewer were run, and the checkout remains clean. (AGENTS.md, 6a805e085493)

Likely related people:

• Free Wortley: Raw commit 22283f6 adds tests/browser/console-agents-list-return.test.mjs:1080 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 22283f690f8a; files: tests/browser/console-agents-list-return.test.mjs)

Labels

Label changes:

• add P3: This repairs browser-test coverage without changing product behavior or establishing a current user-facing failure.
• add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

• P3: This repairs browser-test coverage without changing product behavior or establishing a current user-facing failure.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 19, 2026, 12:25 PM ET / 16:25 UTC.