Repository navigation
docs: distinguish Git identity from repository access - #2955
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR explains that Git commit-author settings are separate from managed GitHub App access. Example: An Agent clones example/project and prepares a commit.
Review scores
ProductKind: Docs · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open for maintainer triage: the focused clarification matches existing behavior, and no actionable defect was found. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherAgents use ordinary Git in their workspace; local Git configuration supplies commit identity, and the repository credential service supplies authenticated GitHub access. flowchart LR
A[Agent workspace] --> B[Git commit]
C[Local author settings] --> B
A --> D[Credential service]
D --> E[GitHub repository]
Technical reviewBest possible solution: Retain the concise explanation beside the existing repository-local Git configuration example. Do we have a high-confidence way to reproduce the issue? No runtime bug is claimed; current source and existing integration scenarios support the documented distinction. Is this the best way to solve the issue? The paragraph is a proportionate clarification of commands already present and introduces no competing configuration or behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 49767aa6c07f. Provenance checked
SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 19, 2026, 2:52 PM ET / 18:52 UTC. |
|
Free’s clanker here. I’d keep this clarification and move the draft to maintainer review. It answers a concrete question at exactly the right spot: a successful clone proves repository access, but doesn’t configure the name and email on the next commit. The hosted Static Checks job covered the author’s local tooling gap: checkout verification, formatting, and documentation check/build all passed on the run for |
|
Free's clanker here. The file now conflicts with #2487, which updated the dedicated-Agent and exact-ref instructions. The clarification still applies. I tested a resolution that keeps main's instructions intact and inserts just the author-identity paragraph between “the TUI client unsets its copy” and “The dedicated Agent works in its workspace.” The resulting guide passed the repository formatter. This preserves the difference between configuring the author on a commit and granting the Agent permission to push. |
Resolve the conflict in docs/guides/repository-credentials.md by keeping main's rewritten text and inserting only this PR's paragraph on Git author identity versus the GitHub App push identity.
|
Free's clanker here (an AI agent working on Free's behalf). I pushed a merge of current main into this branch (a1725d4) to clear the conflict in docs/guides/repository-credentials.md. Main's rewritten lines are kept unchanged; the only diff against main is this PR's paragraph on Git author identity versus the managed GitHub App push identity, inserted between them as described in the earlier comment. Prettier check passes on the file. |
Clarifies author identity vs repository access. git diff --check and git fsck passed; docs tooling unavailable (prettier missing).