Skip to content

docs: distinguish Git identity from repository access - #2955

Merged
freeqaz merged 3 commits into
mainfrom
review/skipper-acceptance-20261019-9205d331
Oct 24, 2026
Merged

freeqaz merged 3 commits into
mainfrom
review/skipper-acceptance-20261019-9205d331

Conversation

@openclaw-enterprise-demo

Copy link
Copy Markdown

Clarifies author identity vs repository access. git diff --check and git fsck passed; docs tooling unavailable (prettier missing).

@clawsweeper

clawsweeper Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:docs Preliminary submission classification; full source review pending. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:docs Preliminary submission classification; full source review pending. labels Oct 19, 2026
@clawsweeper

clawsweeper Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

This PR explains that Git commit-author settings are separate from managed GitHub App access.

Example: An Agent clones example/project and prepares a commit.

  • Before: The guide shows author configuration without explaining why authenticated cloning does not supply it.
  • After: The guide explains that Repository Agent and agent@example.invalid label commits while managed credentials authorize pushes.

Review scores

Measure Result What it means
Overall readiness 🦞 diamond lobster (5/6) A focused, source-supported documentation clarification with no actionable findings; draft status remains a workflow consideration.
Proof confidence 🌊 off-meta tidepool Not applicable: This documentation-only addition changes no executable behavior; source and existing workflow examples were inspected, and no tests or builds were run.
Patch quality 🦞 diamond lobster (5/6) No actionable review findings were identified.

Product

Kind: Docs · Worth it: Yes · Fix scope: Complete
User problem: Operators may confuse successful repository authentication with configuration of commit-author identity.
Reason: The short explanation makes the existing example easier to understand without changing its supported workflow.

Merge readiness

✅ Ready for maintainer review

Keep this PR open for maintainer triage: the focused clarification matches existing behavior, and no actionable defect was found.

Priority: P3
Reviewed head: f28931d1b2662c6475fc04df358663eaf085e2b1

Before merge

None.

Findings

None.

Agent review details

How this fits together

Agents use ordinary Git in their workspace; local Git configuration supplies commit identity, and the repository credential service supplies authenticated GitHub access.

flowchart LR
  A[Agent workspace] --> B[Git commit]
  C[Local author settings] --> B
  A --> D[Credential service]
  D --> E[GitHub repository]
Loading

Technical review

Best possible solution:

Retain the concise explanation beside the existing repository-local Git configuration example.

Do we have a high-confidence way to reproduce the issue?

No runtime bug is claimed; current source and existing integration scenarios support the documented distinction.

Is this the best way to solve the issue?

The paragraph is a proportionate clarification of commands already present and introduces no competing configuration or behavior.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 49767aa6c07f.

Provenance checked

Security

None.

Evidence

What I checked:

Likely related people:

  • Free Wortley: Raw commit 2fd3d79 adds docs/guides/repository-credentials.md:143 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 2fd3d7913258; files: docs/guides/repository-credentials.md)
  • kevinlin-openai: Raw commit 922d5d4 adds docs/guides/repository-credentials.md:139 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: 922d5d44e8e4; files: docs/guides/repository-credentials.md)

Labels

Label changes:

  • add P3: This is a small operator-documentation clarification with no runtime changes.
  • add rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🌊 off-meta tidepool and patch quality is 🦞 diamond lobster.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: This is a small operator-documentation clarification with no runtime changes.
  • rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🌊 off-meta tidepool and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 19, 2026, 2:52 PM ET / 18:52 UTC.

@freeqaz-openai

Copy link
Copy Markdown
Collaborator

Free’s clanker here. I’d keep this clarification and move the draft to maintainer review. It answers a concrete question at exactly the right spot: a successful clone proves repository access, but doesn’t configure the name and email on the next commit.

The hosted Static Checks job covered the author’s local tooling gap: checkout verification, formatting, and documentation check/build all passed on the run for f28931d1. I also applied the paragraph to current main; the three-way file merge was clean and the result passed main’s pinned Prettier 3.9.10. That’s a currentness check, not a claim CI ran on that projected merge. No rebase, credentials, or new live push test needed just to explain this distinction.

@freeqaz-openai
freeqaz-openai marked this pull request as ready for review October 22, 2026 04:52
@freeqaz-openai
freeqaz-openai requested a review from a team as a code owner October 22, 2026 04:52
@freeqaz-openai

Copy link
Copy Markdown
Collaborator

Free's clanker here. The file now conflicts with #2487, which updated the dedicated-Agent and exact-ref instructions. The clarification still applies. I tested a resolution that keeps main's instructions intact and inserts just the author-identity paragraph between “the TUI client unsets its copy” and “The dedicated Agent works in its workspace.” The resulting guide passed the repository formatter. This preserves the difference between configuring the author on a commit and granting the Agent permission to push.

Resolve the conflict in docs/guides/repository-credentials.md by keeping
main's rewritten text and inserting only this PR's paragraph on Git author
identity versus the GitHub App push identity.
@freeqaz

freeqaz commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Free's clanker here (an AI agent working on Free's behalf). I pushed a merge of current main into this branch (a1725d4) to clear the conflict in docs/guides/repository-credentials.md. Main's rewritten lines are kept unchanged; the only diff against main is this PR's paragraph on Git author identity versus the managed GitHub App push identity, inserted between them as described in the earlier comment. Prettier check passes on the file.

@freeqaz
freeqaz merged commit 0678843 into main Oct 24, 2026
21 checks passed
@freeqaz
freeqaz deleted the review/skipper-acceptance-20261019-9205d331 branch October 24, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants