Repository navigation
Conversation
…pace is ready A reader who stayed on the Agents list kept seeing 'Namespace status: Provisioning' after the Namespace turned ready, until Refresh (finding 2058, dogfood D653). Refocus, return and Refresh already recheck the page and rebuild it when the shown Namespace's status changed; nothing did so while the reader stayed. The list now rereads the Namespace at Create Agent's existing 10 s cadence while its note waits on provisioning and, once the status changes, rechecks the page the way a refocus does. A hidden tab stops the wait; a ready Namespace needs no checks.
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Review follow-up for #2984: the timed page recheck rebuilt the list and dropped the reader's focus, and stopped for good when the page recheck could not run (an open dialog). The list now updates the note, Create Agent and the empty-state sentence in place, as Create Agent does (findings 2012, 2024), with the ready note at the warning's height; a hidden tab keeps the timer but reads nothing. The test pins search text and focus across the change and no reads while hidden.
…ready note keep its height The previous commit dropped create.mjs's import of NAMESPACE_RECHECK_MS by mistake (the shared constant now lives in list.mjs). The list's ready note no longer reserves the warning's height: the list holds no field being edited, and at phone width the reserved box read as broken.
clawsweeper
Bot
added
clawsweeper:intake:bug
|
Codex review: needs maintainer review before merge. What this changesThis PR refreshes provisioning Namespace status on the Agents list and updates its guidance without disturbing search or focus. Example: The team Namespace becomes ready while the reader searches for Probe.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: it fixes stale Namespace guidance on current main, and the previous Storybook finding is resolved; no concrete code defect was found. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe Console reads authorized Namespace summaries from OCC and uses their status to display creation guidance and gate the Create Agent control. flowchart TB
A[Visible Agents list] --> B[Ten second readiness check]
B --> C[Authorized Namespace API]
C --> D[Namespace status]
D --> E[Update note and creation control]
Technical reviewBest possible solution: Retain the focused in-place readiness refresh and complete the required visual evidence before merging. Do we have a high-confidence way to reproduce the issue? Current-main source confirms that a reader remaining on the Agents list triggers no periodic Namespace refresh; no target code or tests were run during this read-only review. Is this the best way to solve the issue? The repair uses the existing list owner, Namespace endpoint, readiness rules, and polling cadence while preserving search and row focus. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 14a04fbb64c0. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (1 earlier review cycle)
Reviewed October 19, 2026, 10:05 PM ET / October 20, 2026, 02:05 UTC (Revision 2). |
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
clawsweeper
Bot
added
clawsweeper:intake:bug
1 participant
Problem
Dogfood D653 (board finding 2058, low): the Agents list for a Namespace that becomes ready keeps "Namespace status: Provisioning ... can be deployed once ready" with no recheck. On oce-dogfood-b it stayed ~70 s after the API said ready, until Refresh.
Why: the list already rebuilds when the shown Namespace's status changed (a revalidator from #1895's work), but only when something rechecks the page: a refocus, a return, or Refresh. A reader who stays on the list triggers none of them. Create Agent has its own 10 s recheck while it waits on a provisioning Namespace (#2937, findings 2012/2021-2024); the list had none.
Change
GET /namespacesat Create Agent's existing cadence (NAMESPACE_RECHECK_MS, 10 s, now exported fromagents/list.mjsand imported bycreate.mjs). When the shown Namespace's status changes, it updates the page in place, as Create Agent does (findings 2012, 2024): the warning becomes "Namespace status: Ready. Agents created here can be deployed now." (a polite success status), Create Agent's gate andaria-describedbyfollow the new status, and the empty state's sentence is rerendered. Rows, search text and focus stay.Verification
tests/browser/console-namespace-not-ready.test.mjs, "the Agents list sees its Namespace become ready without a Refresh" (real controller,/namespacesstatus patched on the wire, Playwright clock): one poll keeps the note while provisioning; 30 s withdocument.hiddenmake no read; with "Probe" typed in the search box, the next poll after release shows the ready status, no warning, Create Agent enabled withoutaria-describedby, and the search text and focus unchanged; the empty state then reads the ready invitation; 30 s more make no/namespacesreads. Fails on main sources (the first poll never reads), passes with the change.console-namespace-not-ready+console-namespace-recheck+console-agents-list-return45/45 on the final head;console-retained-revalidationgreen on the first head.git merge-tree, conflict hunks in the touched files) for every open PR touching them (feat: add Gateway managed mode to Agent deployments #2982, feat: share discoverable Driver configuration definitions #2980, Restore the validated Console destination after session expiry #2979, fix(console): header layout and compact Namespace selector #2977, fix(console): let the create preflight carry any configuration both creates accept #2833, feat(console): stop and delete Agents from the Agents list #2524, fix: preserve native plugin permissions across Harness selection and admission #2258, fix(console): grant Agent access to accepted Configuration Secrets #2255, feat(auth): sign people in to occ with a device code (rfc-0019) #1619): identical to main; no new conflict.Screenshots (real controller; the Namespace reads provisioning, then ready; no Refresh, no refocus)
Storybook: new Pages/Agents → Namespace becomes ready story (reuses the
namespaceRechecksfixture support): the provisioning note stays through one recheck, then turns into the ready note with Search Agents keeping its text and focus and Create Agent enabled. Checked by loading the built frame locally.Risks
GET /namespacesevery 10 s per visible Agents list on a provisioning Namespace, the same cost Create Agent already pays. It stops once the Namespace leaves provisioning or the page is left or hidden.