Repository navigation
Conversation
The three Agent facts become a .stats row inside one card (spec 3.5): label, 18 px value, optional help; outcome and Live serving are badges; one column at phone width. The guarantee sentences that sat under facts and cards are said once, in a closed 'What this page can tell you' disclosure under the facts (spec 3.6, plan D5). The deployment panel becomes its own card, and the failed-deployment block gets 32 px below it.
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
…w cards Visual review: at 761-1100 px four facts overran their columns. Stat columns take 16 px padding there and a fourth fact (Stop requested) stacks the row; labels and values no longer break mid-word. The stat and deployment cards are 24 px apart, as in the mockups, and the open chevron sits on the text's centre.
# Conflicts: # apps/controller/src/console/agents/detail.mjs
|
Codex review: needs maintainer review before merge. What this changesThis PR presents Agent facts as responsive stats and consolidates repeated caveats into one expandable disclosure. Example: Version v7 fails while v6 remains selected.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR makes a focused console improvement, and source review found no actionable correctness or security defect. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe Agent detail renderer consumes existing authorized Agent, deployment, and sharing-policy responses and produces console status cards without changing backend operations. flowchart TB
A[Authorized API responses] --> B[Agent detail renderer]
B --> C[Responsive stat card]
B --> D[Deployment evidence card]
B --> E[Page disclosure]
F[Sharing panel visibility] --> E
Technical reviewBest possible solution: Retain the focused presentation change while preserving the existing distinctions between selected, recorded, and verified runtime state. Do we have a high-confidence way to reproduce the issue? This is a presentation enhancement; source comparison and the prepared before/after images establish the existing layout and intended change without executing target code. Is this the best way to solve the issue? The implementation uses the existing renderer, card tokens, badges, and native disclosure element while retaining permission-sensitive status and recovery logic. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against b225870963ba. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Review metrics
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 19, 2026, 11:41 PM ET / October 20, 2026, 03:41 UTC. |
Problem
UX spec P5 (sections 3.5 and 3.6; plan rows S1b and D5). The Agent page shows its three facts (Selected version, Latest visible deployment, Live serving) as a two-column table. The sentences that say what the page cannot confirm are repeated under facts and cards: "Deployment records don't verify live serving or model access." under Live serving, "Selection does not confirm that this version is serving." in the current version's tab notice, and the listed-bindings caveat in the Share Agent panel.
Change
.statsinside a.card). There are three columns with hairlines between them. Each column has a 12 px muted label, an 18 px semibold value (--text-xl) and optional 12 px help. A recorded outcome is the version plus a.badge: Failed is danger, Completed is success, Queued and In progress are info, and Superseded and Stopped are neutral. Live serving is a badge too: "May be offline" is warning and "Not verified" is neutral. At 760 px and narrower the facts form one column, with each label and value on one line. The Runtime "Stop requested" fact, when present, takes a fourth column. The text stays "v7 · Failed": the separator is visually hidden, so screen readers and existing text matches keep it.details.disclosure"What this page can tell you" (an underlined--text-mdsummary with a chevron) sits under the facts. It holds the three guarantee sentences verbatim. The bindings sentence shows only while the Share Agent panel is shown, through a CSS:hasrule. The per-card copies are removed: the Live serving notes, the second sentence of the current version notice, and the bindings clause after "Current policy loaded."badge-and-card-workflow.mdstep 7 walks the stat row and the disclosure.Verification
console-agent-overview.test.mjs:console.css, all three also fail (3/3).Acceptance (spec 5, P5), measured with shots.mjs and a word probe on Storybook stories at 1440:
.statspresentdetails.button--primaryon the failed page / accent / danger (shots)The -40 % overview word target is shared with P6, which moves Share Agent (136 words) to an Access tab. P5 alone removes only the repeated sentences. The 330-word baseline in the spec is from
dd92bd62a; main is at 294.Open-PR conflict map (
git merge-treeof this head and of origin/main against each open PR that touches detail.mjs, access.mjs, console.css, agent-details.md or scenarios.mjs):Media (secret gist): https://gist.github.com/freeqaz/78d0ec71d4a0eeeedc95aed0153e14ab
Failed deployment, 1440 (before / after / mockup):



Failed deployment, 390 (before / after / mockup):



Draft, 1440 (before / after / mockup):



Draft, 390 (before / after):


Disclosure open (1440 failed, 390 draft):


Recordings of the failed story at 1440 and 390, opening and closing the disclosure by click and then by Enter: disclosure-1440.webm · disclosure-390.webm
Risks
:has, which the console already uses for the one-primary rule.