Skip to content

fix(console): say email in the failed sign-in message - #2997

Merged
freeqaz merged 1 commit into
mainfrom
fix-1020b-signin
Oct 20, 2026
Merged

freeqaz merged 1 commit into
mainfrom
fix-1020b-signin

Conversation

@freeqaz

@freeqaz freeqaz commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

#2988 renamed the sign-in field to Email and its hint to "Use your account email.", but a refused password sign-in still said "Could not sign in. Check your username and password." There is no username field any more (finding 2084).

Change

  • The refusal now reads "Could not sign in. Check your email and password." Copy only: no sign-in logic, request or status handling changes. The recovery-only refusal and the 429 / unavailable messages are unchanged.
  • tests/browser/console-status-block.test.mjs waits for the new sentence.

Verification

Screenshots (refused sign-in), before | after:

width before after
1440 signin-error-before-1440 signin-error-after-1440
390 signin-error-before-390 signin-error-after-390

No Storybook story covers the refused sign-in.

Risks

Low. One user-facing string; no doc or story quotes the old text.

The sign-in field is labelled Email since #2988, but a refused password
sign-in still said 'Check your username and password.' (finding 2084).
@freeqaz
freeqaz requested a review from a team as a code owner October 20, 2026 03:41
@clawsweeper

clawsweeper Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Oct 20, 2026
@clawsweeper

clawsweeper Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

This PR changes the failed password sign-in message from “username” to “email” and updates an existing browser assertion.

Example: A user submits operator@example.com with an incorrect password.

  • Before: Could not sign in. Check your username and password.
  • After: Could not sign in. Check your email and password.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The focused patch is correct and visually supported, but the repository's required UI evidence is incomplete.
Proof confidence 🦐 gold shrimp (3/6) Real behavior proof is not required for maintainer- or bot-authored pull requests.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: A refused sign-in tells users to check a username although the form asks for an email address.
Reason: The collaborator-authored correction aligns the error with the already approved Email label without changing authentication behavior.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: it correctly fixes a sign-in copy mismatch still present on current main, with no introduced correctness or security defect found.

Priority: P3
Reviewed head: 89c020607c4f568c8c07bb77ee156794913c0ba9

Before merge

None.

Findings

None.

Tests

  • Missing end-to-end proof: Complete the required visual walkthrough of a refused sign-in using the existing Invalid credentials story or the real console.
Agent review details

How this fits together

The console submits email and password to the authentication API, then maps a refused response to an accessible alert beside the sign-in form.

flowchart LR
  A[Email and password form] --> B[Authentication request]
  B --> C[Authentication API]
  C --> D[Refused response]
  D --> E[Console error mapping]
  E --> F[Accessible sign-in alert]
Loading

Technical review

Best possible solution:

Retain the focused string correction and existing browser coverage.

Do we have a high-confidence way to reproduce the issue?

Current-main source establishes the mismatch, and supplied before screenshots show it at desktop and phone widths; no target code was run during this read-only review.

Is this the best way to solve the issue?

Changing the existing message and updating its existing browser assertion is the smallest complete fix.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 6c5bbd6ff8ce.

Provenance checked

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

Likely related people:

  • freeqaz: Raw commit 6992337 adds apps/controller/src/console/console.mjs:328 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 69923374ecbc; files: apps/controller/src/console/console.mjs)
  • kevinlin-openai: Raw commit 3474bb7 adds apps/controller/src/console/console.mjs:148 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 3474bb717fff; files: apps/controller/src/console/console.mjs)

Labels

Label changes:

  • add P3: This is a small user-facing wording correction; authentication remains functional.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: This is a small user-facing wording correction; authentication remains functional.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Complete the refused-sign-in walkthrough and attach the required screenshot and video evidence.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 19, 2026, 11:56 PM ET / October 20, 2026, 03:56 UTC.

@freeqaz
freeqaz merged commit 7f44e5f into main Oct 20, 2026
80 of 81 checks passed
@freeqaz
freeqaz deleted the fix-1020b-signin branch October 20, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant