Repository navigation
fix(console): say email in the failed sign-in message - #2997
Conversation
The sign-in field is labelled Email since #2988, but a refused password sign-in still said 'Check your username and password.' (finding 2084).
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR changes the failed password sign-in message from “username” to “email” and updates an existing browser assertion. Example: A user submits operator@example.com with an incorrect password.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: it correctly fixes a sign-in copy mismatch still present on current main, with no introduced correctness or security defect found. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe console submits email and password to the authentication API, then maps a refused response to an accessible alert beside the sign-in form. flowchart LR
A[Email and password form] --> B[Authentication request]
B --> C[Authentication API]
C --> D[Refused response]
D --> E[Console error mapping]
E --> F[Accessible sign-in alert]
Technical reviewBest possible solution: Retain the focused string correction and existing browser coverage. Do we have a high-confidence way to reproduce the issue? Current-main source establishes the mismatch, and supplied before screenshots show it at desktop and phone widths; no target code was run during this read-only review. Is this the best way to solve the issue? Changing the existing message and updating its existing browser assertion is the smallest complete fix. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 6c5bbd6ff8ce. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 19, 2026, 11:56 PM ET / October 20, 2026, 03:56 UTC. |
Problem
#2988 renamed the sign-in field to Email and its hint to "Use your account email.", but a refused password sign-in still said "Could not sign in. Check your username and password." There is no username field any more (finding 2084).
Change
tests/browser/console-status-block.test.mjswaits for the new sentence.Verification
node --test --test-name-pattern="Notices and the sign-in alert" tests/browser/console-status-block.test.mjs: on main's source, 1 of 3 pass ("an empty alert block stays in the accessibility tree until its refusal arrives" times out waiting for the new sentence); with the change, 3 of 3 pass.console.mjs(feat(console): Settings with Sign out and session facts #2996, feat: share discoverable Driver configuration definitions #2980, Restore the validated Console destination after session expiry #2979, feat(console): show the authorized native Gateway people roster #2596, feat(auth): sign people in to occ with a device code (rfc-0019) #1619, feat(console): stop and delete Agents from the Agents list #2524, feat: assign configured OpenClaw roles to Agent users #906):git merge-treeagainst this head shows the same conflicted files and hunk counts as against main (no new conflicts).Screenshots (refused sign-in), before | after:
No Storybook story covers the refused sign-in.
Risks
Low. One user-facing string; no doc or story quotes the old text.