Repository navigation
fix(console): name versions and outcomes the same way on the agents list and agent page - #3012
Conversation
… Agent page The Agents list showed the current version as a raw revision ID and the latest deployment as 'v122 · succeeded', while the Agent page called the same outcome 'Completed' (finding 2093). The list now names the current version by number, read with the row's versions (or on its own when it is past the first page), and every outcome label comes from one map.
…land and remember its denial The current version cell waited for the deployment status read and lost its number when that read failed, and an unreadable current version was read (and audited) again on every list view. The cell now fills from the revisions read, the status read runs beside the current version read, and a 403 on the current version is remembered like the Agent page's denied reads (internal review).
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
clawsweeper
Bot
added
clawsweeper:intake:bug
|
Codex review: needs maintainer review before merge. What this changesThis PR displays current Agent versions by number and shares deployment outcome labels across the Agents list and Agent page. Example: teamb-codex has v1 current and v2 as its latest deployment.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: it provides a focused console consistency improvement that main still lacks, and no introduced correctness defect was found. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe console reads Agent revision summaries and deployment records through existing authenticated API requests, then renders version links and recorded outcomes without claiming live serving health. flowchart TB
A[Agents list] --> B[Revision summary page]
B --> C[Current version lookup]
B --> D[Latest deployment record]
C --> E[Version number or ID link]
D --> F[Shared outcome labels]
G[Agent page] --> F
Technical reviewBest possible solution: Land the shared labels and existing revision lookup with the repository-required visual evidence. Do we have a high-confidence way to reproduce the issue? Main's rendering code and the inspected before screenshots establish the inconsistent identifiers and outcome words; no target code was run during this review. Is this the best way to solve the issue? The patch reuses revision summaries, the existing exact-read endpoint and denied-read owner, while consolidating labels without changing API status values or serving-health semantics. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 9c911b458a22. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (2 earlier review cycles)Reviewed October 20, 2026, 2:22 AM ET / 06:22 UTC (Revision 3). |
…n the page's words
…ts Storybook states The flow names currentRevision, its off-page read and the remembered 403. Two duplicated plugin-picker sentences, which the console reference owns, make room under the 2,500-word cap.
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
clawsweeper
Bot
added
clawsweeper:intake:bug
# Conflicts: # tests/browser/console-agent-overview.test.mjs
# Conflicts: # docs/flows/platform-console.md
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
clawsweeper
Bot
added
clawsweeper:intake:bug
Problem
Dogfood round 32 (finding 2093, D663): the Agents list shows the current version as a raw revision ID (
rev_ff04ec12…1680ec) next to "v122 · succeeded", while the Agent page's stat row calls the same outcome "Completed". Deployment details and the version record say "succeeded"/"failed" in lower case.Change
agents/list.mjs: the row's revisions read also finds the current version (it is on the first page in nearly every case; otherwise it is read on its own withGET …/revisions/<id>, beside the deployment status read), and Current version showsvNas soon as that lands. A current version the reader cannot read keeps the old ID link, and its 403 is remembered in the tab's denied reads like the Agent page's, so it is asked (and audited) once. One label map (outcomeLabel: Queued, In progress, Completed, Failed, Superseded, Stopped) names every recorded outcome.agents/detail.mjs: the stat row, "Recorded status:" in Deployment details, "Recorded outcome:" on the version record and the hidden-newer note use the same map.v1in the body font; a new test covers both lookups.docs/flows/platform-console.mdtracescurrentRevision: the shared revisions page, the off-page read beside the deployment read, anddeniedReadsFor. The page is 2124 words after docs(console): split near-cap console reference and flow pages #3013's split.pendingDeploykeeps feat(console): move Share Agent into an Access tab #2999's Access tab entry and reads "Recorded status: In progress". The Versions list outcome badge from fix(console): mark the latest version's outcome and make the Versions list one tab stop #3006 now takes its words fromoutcomeLabel. The flow doc's plugin-picker sentences stay, because docs(console): split near-cap console reference and flow pages #3013 moved them out of this page. Console browser files: 380/380 on the merged head.Verification
current: 'rev_190765bc…de2cf8',deployment: 'v2 · succeeded') and passes with the fix; 20/20 at 2 CPUs. Its second half drops the current version from the revisions page and checks the direct read; its third denies that read and checks it is asked once across a reload (a mutant without the remember fails, 2 reads).Media (fixture: teamb-codex with v1 current and v2 latest, teamb-helper with v1; then teamb-codex's v2 page):
Risks
pendingDeployof console-agent-overview.test.mjs, where both edit the same two lines (its tab, my "Recorded status" word); trivial to resolve, I will merge whichever lands second. It also overlaps my fix(console): show a watched deploy failure as a reload does #3008 on the same test lines. No other new conflicts with fix(console): label a deploying version from its deployment record #3003, fix(runtime): retry network, timeout and 5xx failures of the codex login and model check #2971, feat: add Gateway managed mode to Agent deployments #2982, feat(console): show the authorized native Gateway people roster #2596, feat(console): stop and delete Agents from the Agents list #2524, fix(console): name a Namespace that left the Agents list while it waited #3001.