[freeqaz]

Problem

tests/browser/console-namespace-not-ready.test.mjs:142 "Create Agent names a provisioning Namespace's status before any start" failed true !== false (found in side-by-side lane runs). After switching the harness to OpenClaw, the test waits for the status line "Embedded Agents are saved as drafts..." and then reads create.isDisabled() once.

updateControls() writes that status line from the harness and Namespace alone, but Create Agent also stays disabled while the form's repository discovery (GET .../agents/repository-options) is loading (!repositories.isSettled()). When that read is slow, the line shows while the button is still disabled.

The two "Create Agent waiting on a provisioning Namespace" subtests read isDisabled() the same way after "Dedicated Agents are provisioned and deployed when created." appears.

Change

Wait for Create Agent to become enabled (create.and(page.locator(":enabled")).waitFor()) instead of reading its state once, in those three places. Test-only: disabling Create Agent until the repository choices are known is intended.

Verification

• Deterministic repro on a remote test VM: holding repository-options until after the harness switch leaves Create Agent disabled while the Embedded status line shows (every run); after release it enables.
• Pins on a remote test VM. Whole file, 20 runs at 8 CPUs (the lane's CI CPU count), 5 at a time: 20/20 before and after. The failing test alone, 40 runs at 1 CPU each, 20 at a time: 40/40 before and after; the natural rate is too low to show there, so the held-read repro above is the evidence for the cause.
• Prettier and ESLint clean on the touched file.

Risks

Low. A regression that keeps the button disabled still fails, as a timeout instead of an assertion.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs maintainer review before merge.

What this changes

This PR replaces three immediate Create Agent state assertions with bounded waits for the button to become enabled.

Example: Switch to Embedded OpenClaw while repository-options discovery is still loading.

• Before: The status line appears, but the immediate disabled-state assertion can fail.
• After: The test waits for discovery to finish and Create Agent to enable.

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	The patch is focused and source-supported; validation consists of reported browser-harness runs and successful CI rather than independently inspected deterministic execution evidence.
Proof confidence	🦐 gold shrimp (3/6)	This maintainer-authored, test-only repair is outside the ordinary production-behavior proof gate; reported browser runs and exact-head CI support it without independently proving the deterministic reproduction.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Test only · Worth it: Yes · Fix scope: Complete
User problem: Valid asynchronous form loading can produce a false browser-test failure.
Reason: The maintainer-authored change preserves designed behavior and repairs three instances of the same premature observation.

Merge readiness

✅ Ready for maintainer review

Keep open: this PR makes a focused, source-supported repair to flaky browser assertions without changing production behavior; no actionable defect was found.

Priority: P3
Reviewed head: 116ce8d978f28e2e470b2cd4cf3d7547c4eb0e31

Before merge

None.

Findings

None.

Tests

• Missing end-to-end proof: The held-request reproduction is described, but a captured deterministic base-failure/head-pass comparison is not supplied.

Agent review details

How this fits together

The console form combines Namespace readiness, harness capabilities, and repository discovery to control Agent creation; browser tests observe its status messages and button state.

flowchart LR
  A[Browser test] --> B[Create Agent form]
  C[Namespace readiness] --> B
  D[Harness capabilities] --> B
  E[Repository discovery] --> B
  B --> F[Status and button state]
  F --> G[Bounded enabled wait]

Loading

Technical review

Best possible solution:

Use the existing locator to await enablement while retaining all Namespace, accessibility, and draft-preservation assertions.

Do we have a high-confidence way to reproduce the issue?

Source establishes the timing window, and the author reports reproducing it by holding repository discovery; this review performed no runtime reproduction.

Is this the best way to solve the issue?

The three bounded locator waits directly express eventual enablement without weakening the intended readiness gates or introducing production machinery.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 49019252a2f3.

Provenance checked

• Embedded draft enablement assertion keeps the original intent (f3a7429: Verify that switching away from a Dedicated plan permits saving an Embedded draft in a provisioning Namespace.)
• Namespace readiness recovery assertions keeps the original intent (fix(console): Create Agent re-enables when the Namespace becomes ready #2937: Verify that refocus or polling enables creation after Namespace readiness changes while preserving the draft; later consolidation retained these assertions.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

• Pinned introduced diff: The entire introduced patch changes only three assertions and adds explanatory comments; existing disabled-state, accessibility, Namespace-status, and draft-preservation checks remain. (tests/browser/console-namespace-not-ready.test.mjs:144, 116ce8d978f2)
• Current-main race: The capability status is selected independently of repository settlement, while submit.disabled explicitly includes !repositories.isSettled(); repository discovery calls updateControls after settling. Current main retains the immediate assertions. (apps/controller/src/console/agents/create.mjs:2248, 49019252a2f3)
• Bounded failure remains: Browser pages use a 10-second default timeout, so a button that remains disabled still fails the changed tests. (tests/browser/console-agents-browser-helpers.mjs:158, 116ce8d978f2)
• Original behavior and ownership: fix(console): small refusal and focus fixes from the 10-19 audit #2930 established the Dedicated-plan gate and Embedded-draft recovery; fix(console): Create Agent re-enables when the Namespace becomes ready #2937 established readiness recovery while preserving the draft; test(console): consolidate the console browser tests added since #2903 #2947 consolidated these tests. This PR preserves those contracts. Local history consistently identifies Free Wortley; deeper content searches encountered unavailable historical blobs, so earlier introduction is not inferred. (tests/browser/console-namespace-not-ready.test.mjs:142, f3a74292ab69)
• Exact-head checks: GitHub reports Console Browser, Static Checks, Suite Audit, CI Required, and hosted-target admission successful for the reviewed head. Browser job logs redirected to a blocked artifact host and could not be inspected; no local tests were run. (116ce8d978f2)
• Repository policy applied: Read the root instructions and applicable testing skills; no nested test instructions, maintainer-notes directory, or pr-simplify skill were found. The patch adds no platform functionality requiring new integration coverage, changes no UI requiring new media, and leaves the checkout clean. (AGENTS.md, 116ce8d978f2)

Likely related people:

• Free Wortley: Raw commit f3a7429 adds tests/browser/console-namespace-not-ready.test.mjs:136 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: f3a74292ab69; files: tests/browser/console-namespace-not-ready.test.mjs)

Labels

Label changes:

• add P3: This is a narrowly scoped browser-test reliability repair with no production behavior change.
• add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

• P3: This is a narrowly scoped browser-test reliability repair with no production behavior change.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 20, 2026, 11:41 PM ET / October 21, 2026, 03:41 UTC.