Repository navigation
test(console): wait for enabled controls in the agent logs and overview tests - #3169
Merged
Merged
Conversation
…ew tests Six one-shot expect-enabled reads that follow a wait move onto the shared waitForEnabled helper (finding 2116 leftovers). The Refresh read during a held poll stays one-shot: it asserts a moment.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#3167 moved one-shot "expect enabled" reads that follow a wait onto the shared
waitForEnabledhelper, but leftconsole-agent-logs.test.mjsandconsole-agent-overview.test.mjsalone while another change was editing them. Both files still read a control's enabled state once right after waiting for some text, so under load the read can see the state from just before the page settles.Change
console-agent-logs.test.mjs: the two#runtime-log-sourcereads after the log text appears (first visit and the reopened Logs tab) usewaitForEnabled.console-agent-overview.test.mjs: the Share Agent Principal ID input after "Current policy loaded.", the version button before and after a held share, and Deploy on the draft next-step card usewaitForEnabled.Verification
Risks
Test-only. A wait for "enabled" would also pass if a control flickered disabled and back; the moved reads follow a wait for a settled state, and the reads that assert a moment stay one-shot.