[freeqaz-openai]

Move the Console’s shell, keyboard focus, and button hierarchy browser tests to strict TypeScript. Typing their simulated HTTP 400 responses caught three uses of VALIDATION_FAILED, an error code the controller cannot return. Those tests now use INVALID_REQUEST and still check that the controls recover from the refusal.

All 23 existing cases passed in sandboxed Chromium on both main and this change, with identical case names and order. The existing CI lanes, file order, and duration weights are unchanged. Repository typecheck, lint, formatting, and CI test discovery checks passed.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs maintainer review before merge.

What this changes

This PR converts three Console browser suites to strict TypeScript, corrects three simulated error codes, and updates their CI references.

Example: A browser scenario simulates a refused Save Configuration request with HTTP 400.

• Before: The fixture uses VALIDATION_FAILED, which is outside the controller error contract.
• After: The typed fixture uses INVALID_REQUEST and retains the assertion that Save becomes available again.

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	A focused, useful test migration with no identified defect; validation consists of browser-harness results and CI rather than a changed shipped behavior.
Proof confidence	🦐 gold shrimp (3/6)	This maintainer-authored test-only migration changes no shipped behavior; reported Chromium comparisons and passing head-bound browser lanes support preservation of the scenarios.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Test only · Worth it: Yes · Fix scope: Complete
Reason: Strict checking catches unsupported fixture responses while retaining established browser coverage; the maintainer-authored direction needs no additional product decision.

Merge readiness

✅ Ready for maintainer review

Keep open: this maintainer-authored PR provides useful contract checking for existing browser coverage, with no actionable defect found in the introduced diff.

Priority: P3
Reviewed head: 7599b237adabb8d40c9e5a8eb99c554cf376df44

Before merge

None.

Findings

None.

Agent review details

How this fits together

Playwright scenarios exercise the Console through a fixture controller, using selected simulated dependency responses and checking rendered controls, keyboard focus, and recovery states.

flowchart TB
  A[CI suite manifests] --> B[Typed browser scenarios]
  B --> C[Playwright Chromium]
  C --> D[Console and fixture controller]
  D --> E[Rendered state assertions]

Loading

Technical review

Best possible solution:

Retain the focused TypeScript conversion with the existing scenarios and CI scheduling preserved.

Do we have a high-confidence way to reproduce the issue?

No runtime bug reproduction is required for this test migration; source inspection confirms the three original fixture codes violate the controller error contract.

Is this the best way to solve the issue?

The conversion uses existing contracts and helpers, preserves meaningful assertions, and updates every active CI reference to the renamed files.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against e658b22c09e9.

Provenance checked

• Console browser assertions keeps the original intent (test(console): pin busy states, badge tones and the focus-ring clip axis #2908: Protect recovery from refused saves, degraded configuration badges, and focus-ring clipping on each axis.)
• Shared login helper keeps the original intent (perf(test): sign fresh console browser tabs in through the password api #3094: Use password API sign-in for fresh loopback tabs while retaining form sign-in for other scenarios.)
• CI duration metadata keeps the original intent (test(ci): add five duration rows and refresh console-focus-ring's #3011: Schedule browser files using measured duration weights.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

• Introduced scope: The pinned introduction contains three test renames, type annotations and narrowing assertions, three error-code corrections, CI path substitutions, and one helper JSDoc annotation; it changes no production implementation. (7599b237adab)
• Controller error contract: ErrorResponse includes INVALID_REQUEST; the refusal helper now constrains its code and serialized envelope to that contract. (packages/contracts/src/api/common.ts:940, 7599b237adab)
• Current-main context: The three original JavaScript suites are unchanged between the introduction base and fetched main, so this migration remains distinct work. (e658b22c09e9)
• Preserved regression coverage: The scenarios retain the busy-state, degraded Agent response, and axis-specific focus-clipping protections explained in test(console): pin busy states, badge tones and the focus-ring clip axis #2908. (tests/browser/console-button-hierarchy.test.ts:726, 7599b237adab)
• Head-bound validation: GitHub reports success for both Console Browser lanes, Static Checks, Suite Audit, and CI Required on the reviewed head. Detailed job-log retrieval was blocked by the sandbox's artifact-host allowlist, so individual test output was not independently inspected. (7599b237adab)
• Discussion and policy: The complete body records the 23-case Chromium comparison; both comments are review-status notices and there are no submitted reviews. Captured sourceRevision is be5f37c001b558212d0fa0140f02c2923cf80733e098a1f34a88d7952afab3e1. The full root AGENTS.md was read; no nested AGENTS.md or maintainer-notes directory was found in the touched scope. (AGENTS.md, 7599b237adab)

Review metrics

Metric	Value	Why it matters
Preserved browser scenarios	23 cases: 10 button hierarchy, 4 focus ring, 9 shell	The conversion retains existing scenario names and order without adding duplicate test groups.

Labels

Label changes:

• add P3: This is bounded test maintenance with no production behavior change.
• add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

• P3: This is bounded test maintenance with no production behavior change.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 22, 2026, 7:59 AM ET / 11:59 UTC.