Repository navigation
docs(credential-proxy): trace the operation slot handoff in the request flow - #3287
Merged
Merged
Conversation
…st flow Follow-up to #3284, which landed before this review item was pushed: the request flow now says resolve reserves an authentication slot before verification and moves it to the verified Sandbox's share afterwards. The doc stays at 2499 words, as on main.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#3284 gave each Sandbox its own share of the Credential Proxy's in-progress operations. A request's slot now counts toward a global authentication budget until
verifyPeersettles, and then toward the verified Sandbox's share. That PR's review asked for the request flow to trace this handoff. #3284 landed before the docs commit reached it, sodocs/flows/credential-source-egress.mdstill describes a single generic slot.Change
Docs only. In the request-time trace of
docs/flows/credential-source-egress.md:resolvereserves an authentication slot before verification.docs/reference/drivers/credential-proxy.md), which fix(credential-proxy): give each sandbox its own share of in-progress operations #3284 updated.The doc stays at 2499 words, as on main, under the 2500-word cap.
Verification
node scripts/docs-site/word-count.mjs: the file is 2499 words (main: 2499).node scripts/docs-site/build.mjs --checkwas clean with the same edit on the fix(credential-proxy): give each sandbox its own share of in-progress operations #3284 branch (290 pages, 4556 links).Risks
None. This is a wording change only.