[freeqaz-openai]

The Namespace Storybook scenarios now focus Create Namespace before their scripted click. A programmatic click does not focus a button, so Escape previously closed the dialog but left focus on the page. The scenarios now reproduce a real click: Escape returns focus to the opener. This changes fixture setup only.

Updated two dogfood guides to match the actual Console: End focuses Access on the First version story; Enter opens it. A long theme name wraps in the drawer while the phone bar truncates it to keep controls reachable.

Verified against the built Storybook in Chromium at 390px: scripted Escape failed to restore focus before the change and restored it afterward; a real click restored focus on both. Also verified Access → Workspace files → Back twice returns focus to Configuration and the full theme name is visible in the drawer. The static build, changed fixture lint/format, and diff checks passed. Storybook uses simulated API state.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs maintainer review before merge.

What this changes

This PR focuses Namespace dialog openers in Storybook and corrects keyboard-navigation and mobile-theme walkthroughs.

Example: Open the Create Namespace mobile story at 390px and press Escape.

• Before: The scripted click opens the dialog without focusing its opener, leaving focus on the page after dismissal.
• After: The scenario focuses Create Namespace before clicking, allowing dismissal to restore focus to that button.

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	The source supports a narrow, correct repair; browser verification is reported in prose rather than independently inspectable artifacts.
Proof confidence	🦐 gold shrimp (3/6)	This collaborator-authored fixture-maintenance PR is outside the ordinary contributor proof gate and changes no production UI; its Chromium verification account has no attached trace or media for independent inspection.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: Contributors can mistake fixture-induced focus loss and outdated walkthrough expectations for Console defects.
Reason: The collaborator-authored change corrects reproducible preview setup and inaccurate instructions while preserving the intended product contracts.

Merge readiness

✅ Ready for maintainer review

Keep open for maintainer triage. This PR makes a focused fixture repair and corrects instructions to match current Console behavior; no actionable defects were found.

Priority: P3
Reviewed head: a8fcc1983d3831220dda6c3ca681870626a6a382

Before merge

None.

Findings

None.

Agent review details

How this fits together

Storybook feeds scenario actions and simulated API responses into the production Console components; these changes affect preview setup and contributor walkthroughs.

flowchart TB
  A[Storybook scenario] --> B[Preview action runner]
  B --> C[Focus and click opener]
  C --> D[Production Namespace dialog]
  D --> E[Browser restores focus]

Loading

Technical review

Best possible solution:

Retain the existing production behavior and apply these focused fixture and walkthrough corrections.

Do we have a high-confidence way to reproduce the issue?

Source establishes the unfocused scripted click and the stale walkthrough expectations; no target code, builds, or tests were executed during this read-only review.

Is this the best way to solve the issue?

The patch uses the existing focus action and corrects instructions against their current owners, providing a small, complete repair without introducing another behavior path.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against a8d0bd51fff5.

Provenance checked

• Namespace story setup keeps the original intent (5a2cb36: feat(console): add Namespace creation #2961 added creation stories; fix(console): stop inviting members to create namespaces they cannot create #2983 added the refusal story.)
• Keyboard walkthrough keeps the original intent (4e45875: feat(console): tabs with tablist semantics #2878 documented manual tab activation and focus restoration; the revised destinations match the current tab inventory.)
• Theme walkthrough keeps the original intent (9d67782: feat(console): support deployment-wide theme bundles #3048 added deployment branding and its walkthrough; the clarification distinguishes existing drawer wrapping from top-bar truncation.)

Testing

Proof path: none.

Security

None.

Evidence

What I checked:

• Verified introduced scope: The pinned introduction diff changes eleven existing opener actions and two walkthroughs; current main has none of these changes. (scripts/console-storybook/public/scenarios.mjs:1367, a8fcc1983d38)
• Existing fixture mechanism: The preview runner already processes action.focus before action.click, so the repair needs no runner or production changes. (scripts/console-storybook/public/frame.mjs:77, a8fcc1983d38)
• Keyboard instructions match implementation: The draft tab order ends with Workspace files, Policy denials, and Access; End selects the last focus target, and two Left presses from Access reach Workspace files. (apps/controller/src/console/agents/detail.mts:552, a8fcc1983d38)
• Theme instructions match styles: Brand names wrap normally, while the top-bar variant explicitly uses hidden overflow, ellipsis, and nowrap. (apps/controller/src/console/console.css:450, a8fcc1983d38)
• Production focus contract already covered: The existing browser test clicks the real opener, presses Escape, and asserts focus returns without creating a Namespace; the fixture repair preserves this contract. (tests/browser/console-namespace-create.test.mjs:54, a8fcc1983d38)
• Maintainer direction and verification account: The author is a collaborator and reports before/after Chromium checks at 390px, explicitly identifying Storybook state as simulated; the full body and both comments contain no linked current-change media or traces. (a8fcc1983d38)

Labels

Label changes:

• add P3: The changes repair developer previews and verification instructions without changing deployed product behavior.
• add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

• P3: The changes repair developer previews and verification instructions without changing deployed product behavior.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 23, 2026, 6:14 AM ET / 10:14 UTC.