Repository navigation
fix(test): make the k3d-model lane report only tests that run - #3308
Merged
Merged
Conversation
The k3d-model manifest expected "production dedicated OpenClaw runs worker-local inference and tools in an enrolled Harness pod", which no test ever defined: 10af5b8 added the expectation without the test, and dedicated native OpenClaw is proven by the openshell lane. Drop it. The Skill source upload case skipped unless OCC_TEST_SKILL_SOURCE_LIFECYCLE=1. #843 gated it for candidate images; #1414 put paired-node Skill uploads in the default runtime three days later, so the gate only made the lane report an unexpected skip. Select it like the other production cases, drop "candidate" from its name, and list it in the manifest. The teardown conformance test no longer needs the env to reach it, and the Kubernetes testing guide counts six cases. Findings 1757 and 1758.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The k3d-model lane reports two issues on every run, even when every case passes, which hides real failures:
missing-expected-test:scripts/ci/test-suites/k3d-model.jsonexpects "production dedicated OpenClaw runs worker-local inference and tools in an enrolled Harness pod". No test has ever had that name. 10af5b8 (dedicated native OpenClaw harness) added the expectation and a helper branch (arrangeProductionTopologyharnessId,assertNativeWorkerTurn) but no test. No test passesharnessId: "openclaw", so dedicated native OpenClaw on Kubernetes Compute has no real-cluster test. The openshell lane covers native OpenClaw only through the OpenShell sandbox driver. That gap is tracked separately; this PR only stops the lane from reporting a test that does not exist.unexpected-skip: "candidate dedicated Skill source uploads honor default and denied node-write policy" skips unlessOCC_TEST_SKILL_SOURCE_LIFECYCLE=1, which the lane never sets, and the runner no longer accepts declared skips. fix: authorize dedicated Skill lifecycle storage paths #843 added the gate for candidate images with paired-node Skill uploads. build(runtime): adopt paired-node Skill lifecycle and Codex 0.160.0 #1414 put that support in the default runtime three days later, so the gate only hides the test. It is the only real-cluster coverage of Skill uploads under default and denied node-write policy.Change
requiresProductionCluster, like the other production cases. Rename it "production dedicated Skill source uploads ..." and list it in the manifest.arrangeProductionTopology.docs/testing/kubernetes.md: count six non-Slack cases, note that the Skill case needs localzip, and drop the opt-in recipe.Verification
node scripts/ci/run-tests.mjs audit: passed, 0 issues.+concatenation and re-exported files are resolved. Every other env-gated skip in a mapped file is set by the lane'senv,requiredEnvorscripts/ci/prepare.mjs. So this was the only mismatch of either kind.every production topology test stops its worker before the platform Namespace delete: passes 20/20 at 2 CPUs. With the old gate restored and no env set, it fails ("arranged a topology in every test"), so it now guards the case.harness-topology-k3d-real.test.mjsunselected skips all six cases with the standard prerequisites message.Risks
zipon the runner.ubuntu-24.04hosted runners include it.k3d-model.jsonand keeps the dead expectation. Whichever lands second needs a trivial merge.