Repository navigation
docs(deploy): read breaking-change notices from the source commit's date - #3566
Merged
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Breaking-change notices carry a date, not a commit. The page told operators to read every entry "dated after the source commit". In a dogfood upgrade from a build of 2026-10-24 23:16 UTC, six 2026-10-24 notices that landed later that day (#3550), plus the 2026-10-24 placement notice that #3537 changed, are not "dated after" that commit. An operator who follows the text exactly skips them.
Change
docs/guides/deploy/breaking-changes.md: read every entry dated on or after the date of the source commit. The text also says that an entry from that day can be newer than the commit.Verification
Docs only. Prettier check passes on the file. The upgrade that found this used a remote test install and went from
36463e9f77to2b1f510594.Risks
None. Operators read at most one extra day of entries.