Repository navigation
test(console): mark the agent name only for the taken-name sentence and list paged revision outcomes - #3617
Merged
Conversation
Create Agent marks the name field when the preflight, provisioning admission or Agent create answers 409 with the taken-name sentence. Treating any 409 as taken survived on all three paths; another conflict would mark the field and say the name is taken. The browser tests now send another 409 on each path and check that the field stays unmarked.
…ast revision listRevisions returns early when a page fills before the last revision. Dropping the outcomes on that path survived: every test listed all revisions on one page. The superseded-retry test now lists one revision per page and checks both outcomes.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: test(console): mark the agent name only for the taken-name sentence and list paged revision outcomes This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A mutation sweep of #3597's Create Agent name mark (
create.mts) and #3598's revision marks (detail.mts,list.mts, and the OCC revision list'sdeploymentStatus/deploymentErrorCode) left these changes uncaught:listRevisionsreturns early when a page fills, and that path is a separate return. Every test listed all revisions on one page, so null outcomes on that path survived. On an Agent with more versions than one page holds, the console would lose the Failed mark after a reload.The rest was killed or is equivalent.
Change
Test only:
tests/browser/console-create-agent-provisioning-400.test.mjs: the first provisioning admission answers a plain 409. The name field stays unmarked, and the real taken-name 409 follows.tests/browser/console-agents-2.test.ts: the preflight answers a 409 with another conflict, and the field stays unmarked. Agent create's other 409 also leaves the field unmarked.tests/integration/postgres-worker-agent-revision.test.mjs: the superseded-retry test lists one revision per page and checks both outcomes and the cursor.The faked answers use
apiErrorResponse(#3615).Verification
postgres-applicationdatabase. tsc, prettier and eslint pass.Equivalent:
Risks
Test only. It adds about 2 s across three files.