Repository navigation
fix(console): log, diagnostics and empty-list text match the api and cli - #3713
Merged
Merged
Conversation
Logs name the API's log text grant, Agent read_logs (or Agent administer), from access-reasons. Diagnostics show a version without Slack as not set up and not checked instead of failed (NOT_CONFIGURED). An empty Agents list for a member without create says none are shared with them. Page-level permission refusals drop Retry (the header's Refresh checks access again), and the remaining 'an administrator' asks name an Installation administrator.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(console): log, diagnostics and empty-list text match the api and cli This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dogfood round 44 (findings D746, D733, D734) found console refusals that say something different from the API and the CLI for the same refusal, or that show raw codes:
Agent read_logs (or Agent administer)and say who grants it.failed (NOT_CONFIGURED)andunknownrows, as if something failed.403panels offered Retry, which gives the same answer, and one 403 named no one to ask.Already fixed on main by #3695/#3696 (checked, not changed here): "Ask its owner to share it with you.", the Driver configurations sentence, the bound Secret metadata 403 and the empty Secrets list.
Change
access-reasons.mts:LOG_TEXT_GRANT,LOG_TEXT_DENIEDandRUNTIME_STATUS_DENIED, used by the Logs section and the network policy log grant. The text namesAgent read_logs (or Agent administer)and asks an Installation administrator.not set up/not checkedinstead offailed (NOT_CONFIGURED)/unknown, with a plain hint.403shows no Retry (the header's Refresh checks again after a grant); the Request ID stays as secondary detail. The Agent read refusal names who to ask.docs/guides/console/agent-details.md(diagnostics rows).runtimeLogTextDenied("Runtime status and log text refused"),diagnosticsNoSlack("Current observations for a version without Slack") andagentsEmptyMember("Empty for a member").Verification
console-agent-logs,console-agent-overview,console-agent-state,console-agent-detail,console.test.mjs. The changed assertions fail on main (checked in a separate worktree with only the test changes applied).checks-browserlane passed on a remote test VM before the last test fix; CI is the authority for the final head. A 20/20 pin of the changed browser tests is owed and will be run when the test VM is reachable again.Risks
Media (Storybook, before then after)