Skip to content

docs: clarify Gateway tool policy edits with managed mode off - #3802

Merged
stevenlee-oai merged 1 commit into
mainfrom
dev/stevenlee/docs-gateway-tool-policy-off-mode
Oct 27, 2026
Merged

stevenlee-oai merged 1 commit into
mainfrom
dev/stevenlee/docs-gateway-tool-policy-off-mode

Conversation

@stevenlee-oai

Copy link
Copy Markdown
Contributor

RFC 21 now describes what an authorized Gateway admin can change after an Installation admin turns Gateway managed mode off and deploys. OCE still installs the saved tool policy at launch. If a Gateway admin explicitly widens it, subsequent model turns can use the added tools after a native Gateway restart. Redeploying with managed mode on restores OCE’s saved policy.

This documentation-only follow-up updates the RFC and operator references for the behavior shipped in #2633 and #2982.

Verification

  • On feat(runtime): apply Gateway tool policy to dedicated OCE deployments #2633’s merged-source images, a deterministic model issued agents_list before an admin edit, after the native Gateway restart, and after OCE re-enabled managed mode. The call succeeded only in the middle phase. On re-enable, the same OC session retained its permitted get_goal call and the Gateway refused the admin’s next config.patch. Tested runtime · Tested controller
  • pnpm docs:check passed on this branch with 304 pages, 4,754 links and 96 spec documents. Prettier passed for all four changed files.

@stevenlee-oai
stevenlee-oai requested a review from a team as a code owner October 27, 2026 00:13
@clawsweeper

clawsweeper Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:docs Preliminary submission classification; full source review pending. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:docs Preliminary submission classification; full source review pending. labels Oct 27, 2026
@clawsweeper

clawsweeper Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

Clarifies that authorized Gateway admins can widen the local tool allowlist with managed mode off, while redeployment restores OCE’s saved policy.

Example: A Gateway admin adds agents_list while gatewayManagedMode=false.

  • Before: The documentation implies that OCE’s saved allowlist cannot be widened locally.
  • After: The documentation explains that a native restart activates the added tool and redeploying with managed mode on removes it again.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) Useful, focused documentation supported by current source and recorded native-runtime qualification; no actionable findings.
Proof confidence 🌊 off-meta tidepool Not applicable: Documentation-only change; the linked feature-owner record supports the native restart and managed-redeployment behavior, while predecessor UI media is simulated and does not prove tool execution.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Docs · Worth it: Yes · Fix scope: Complete
User problem: Operators could incorrectly assume that the OCE-saved allowlist remains immutable during local experimentation with managed mode off.
Reason: The feature owner has explicitly confirmed the direction, and the clarification matches current implementation and recorded runtime outcomes.

Merge readiness

✅ Ready for maintainer review

Keep this PR open for landing: it accurately documents the intended off-mode behavior already on main, and no actionable defect was found.

Priority: P3
Reviewed head: 200ea71656ad2bec9f68d7fbe202cf8b12151e64

Before merge

None.

Findings

None.

Agent review details

How this fits together

OCC snapshots Agent configuration, Compute installs its Gateway policy at launch, and the Gateway applies the active policy to model tool calls.

flowchart TB
A[Saved Agent revision] --> B[Compute launch wrapper]
B --> C[Gateway configuration]
D[Authorized Gateway admin] -->|Edit with managed mode off| C
C -->|Native restart| E[Active tool policy]
E --> F[Model tool calls]
A -->|Redeploy restores policy| C
Loading

Technical review

Best possible solution:

Land the focused clarification so operators understand local policy edits, native restart activation, and restoration on redeployment.

Do we have a high-confidence way to reproduce the issue?

This PR corrects documentation; source inspection and the linked native-runtime qualification support its described behavior without executing target code.

Is this the best way to solve the issue?

The change updates the existing reference pages and working RFC, explains the activation and restoration boundaries, and introduces no competing implementation.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 09e9cb6e4a45.

Provenance checked

  • Gateway managed-mode reference keeps the original intent (110aea3: Default-on controls restrict direct Gateway administration while allowing administrator-approved local experimentation.)
  • Gateway tool-policy reference keeps the original intent (36fb718: Install the saved revision’s policy at launch and apply it after ordinary Agent and plugin grants.)
  • Working RFC off-mode invariant changes intended behavior with a stated reason (92ee883: The original proposal required the Harness policy to remain unwidenable in either mode; the owner now explicitly identifies local widening while off as intended behavior and supplies native-runtime results.)

Security

None.

Evidence

What I checked:

Likely related people:

  • stevenlee-oai: Raw commit 110aea3 adds docs/reference/agents/gateway-managed-mode.md:3 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 110aea3888bb; files: docs/reference/agents/gateway-managed-mode.md)

Labels

Label changes:

  • add P3: This is a focused operator-documentation correction with no executable behavior change.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: This is a focused operator-documentation correction with no executable behavior change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 26, 2026, 8:26 PM ET / October 27, 2026, 00:26 UTC.

@stevenlee-oai
stevenlee-oai merged commit afc47d3 into main Oct 27, 2026
45 checks passed
@stevenlee-oai
stevenlee-oai deleted the dev/stevenlee/docs-gateway-tool-policy-off-mode branch October 27, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant