Repository navigation
Route Agent plugin catalogs by Harness in mixed Installations - #4174
stevenlee-oai wants to merge 7 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR proposes enabling both bundled plugin catalogs and selecting one for each Agent by its Harness. Example: One Installation hosts a dedicated OpenClaw Agent using Google Workspace and a dedicated Codex Agent using Linear.
Review scores
ProductKind: Docs · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open for maintainer triage: it proposes a useful capability absent from main, and no actionable defect was found in the RFC-only diff. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherTrusted Installation configuration supplies Plugin Drivers; OCC uses Agent Harness and selection state for discovery and admission, then Compute prepares the plugin runtime from the admitted revision. flowchart TB
A[Installation catalog inventory] -.-> B[Proposed Harness selection]
C[Agent Harness and selections] -.-> B
B -.-> D[Authorized catalog discovery]
B -.-> E[Revision admission]
E -.-> F[Pinned driver identity]
F -.-> G[Compute plugin preparation]
Technical reviewBest possible solution: Retain this RFC as the proposed plugin-specific contract and assess implementation against its ownership, credential-routing, and pre-cutover refusal requirements. Do we have a high-confidence way to reproduce the issue? No bug reproduction applies; current-main composition and startup coverage confirm the single-catalog limitation motivating the proposal. Is this the best way to solve the issue? The proposal extends existing Installation composition, Plugin Driver selection, and revision admission while explicitly addressing stored ownership and the intentionally retired pairing. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 32f1476071e4. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 30, 2026, 3:39 AM ET / 07:39 UTC. |
|
Free's clanker here (an AI agent working on Free's behalf). ⭐ CI-support diagnosis for head The log reports two concrete provisioning-test failures:
Separately, This is not just missing CI capacity: the provisioning assertions need investigation before an unchanged-head rerun would be useful. No duplicate manual CI run started. |
…e-plugin-drivers # Conflicts: # tests/integration/production-image-upgrade-recovery.test.mjs
|
Free's clanker here (an AI agent working on Free's behalf). Heads-up: #4098 landed |
An operator can enable both bundled catalogs in one Installation. OpenClaw Agents use
occ-pluginin embedded and dedicated mode. Dedicated Codex Agents usecodex-plugin. Agent authors select the Harness, and the Console opens its catalog automatically.To replay the Console flow, run
pnpm storybookand open Pages / Create Agent / Select Linear from the curated catalog. Add Linear under Codex, then change to OpenClaw. The Codex selection clears and the picker shows the instructions for Google Workspace on a saved dedicated Agent. This story uses controlled fixtures.Behavior
Verification
On the current head, 164 tests across controller lifecycle, startup, discovery and Agent APIs passed on the OCE DevBox. A failed change from two catalogs to one preserves the existing Compute hooks. A successful change replaces them with the remaining driver’s hooks. Four image-upgrade checks also passed, along with formatting, TypeScript and workspace checks.
Mixed-installation HTTP tests discovered, saved and admitted Google Workspace and a Codex plugin for separate dedicated Agents. Browser tests exercised Harness changes. Four PostgreSQL worker regressions covered refusal before predecessor stop, continued maintenance, ordinary Stop, and standing Git authorization after catalog removal. Migration and restore tests covered an existing populated database. Compute, startup and repository-admission tests passed 197/197. Repository runtime material tests passed 119/119. The existing QA matrix now keeps both catalogs enabled across Agent presets.
A live Google Workspace operation and a Codex plugin tool call on the same Installation still need an authorized test account. The recorded Storybook walkthrough is available to the author locally. Uploading it as PR media is pending.
RFC-0026 · CI for the current PR head