Repository navigation
fix(occ): accept nested-slash model IDs - #875
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review blockedAutomated review did not run, so no review verdict was produced. Reason: The input-safety check rejected material in this revision. No detected value, path, or scanner output is reproduced here. Automatic review is on hold, including after source changes. Request a fresh re-review after resolving the failure; maintainers can also release the hold through an intentional scanner-policy update. Next step: If this is a genuine credential, remove and rotate it. If it is an intentional test fixture, a maintainer must review and qualify it. |
|
If you work with OpenRouter-style model IDs like these, you might also like to try https://github.com/llmmanorg/llmman. Thanks! |
|
CI is waiting for workflow approval. Could a maintainer approve the run? Thanks. |
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
|
Tested Real deployment: local k3d, Kubernetes Compute, embedded OpenClaw, model ref
Checks listed as not run, on that tree:
Getting that reasoning model to an active revision also needed a larger startup probe token cap, which is unrelated to this change: #920. |
|
Free's clanker here (an AI agent reviewing on Free's behalf). Checked head a6c4c02 against main 10a9756 (the merge is clean). The code change is right: Verdict: needs one small change, then it is ready for a maintainer to merge once
Ordering: this should land before #913 and #923. #913 rewrites the same catalog-id comparison in |
|
Free's clanker here (an AI agent reviewing on Free's behalf). CI follow-up for run 36945652675: the only failing job is Checks and Conformance, in the docs length check ( The code and tests pass. That run merged this branch into an older main (7a6cc93). Against current main (04d01d0) the page is 2495 words and this PR brings it to 2516, so it still fails after a sync. What to do: merge current main, then trim at least 16 words from |
|
Merged main and trimmed harness-execution.md by about 20 words to clear docs:check-length. Thanks for the reviews. |
|
Free's clanker here (an AI agent reviewing on Free's behalf). Landed as 04f2f51 with Free's authorization, after an independent review of head 23a3f53. What the review checked:
Thanks for the fix and the docs trim. Next: #913 needs to drop its overlapping catalog-id edits in |
Problem
Model IDs with slashes (
openai/vendor/model) fail admission. Fixes #813.Change
Split model refs at the first slash with one shared helper.
Verification
configured-harness.tsrun alone with the issue config: fails onmainwith the reported error, passes now.configuration-occandkubernetes-computeconformance tests.main): revision admitted, full three-segment ID reaches the provider with HTTP 200. Both conformance files: 229 pass. eslint, prettier on changed files, andpnpm typecheck: pass.pnpm test:conformance, repo-widepnpm lint(no installed deps here).Risks
Low. A catalog ID of only the first segment (
vendor) is no longer accepted.