Skip to content

[Localization Audit] fix: add x:Uid to 9 hard-coded XAML strings (AgentEventsPage, SessionsPage, SkillsPage, VoiceSettingsPage, HubWindow) #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

[Localization Audit] fix: add x:Uid to 9 hard-coded XAML strings (AgentEventsPage, SessionsPage, SkillsPage, VoiceSettingsPage, HubWindow) #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenClaw.Tray.WinUI/Pages/AgentEventsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
Background="#20FF4444">
<StackPanel Orientation="Horizontal" Spacing="4">
<Ellipse x:Name="LiveDot" Width="6" Height="6" Fill="#FFFF4444" VerticalAlignment="Center"/>
<TextBlock x:Name="LiveText" Text="Live" FontSize="11" FontWeight="SemiBold"
<TextBlock x:Uid="AgentEventsPage_LiveText" x:Name="LiveText" Text="Live" FontSize="11" FontWeight="SemiBold"
Foreground="#FFFF4444" VerticalAlignment="Center"/>
</StackPanel>
</Border>
Expand Down
8 changes: 4 additions & 4 deletions src/OpenClaw.Tray.WinUI/Pages/SessionsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
Text="Sessions"
Style="{StaticResource TitleTextBlockStyle}"
Margin="0,0,0,2"/>
<TextBlock Text="Conversations this gateway is currently handling, grouped by channel."
<TextBlock x:Uid="SessionsPage_Subtitle" Text="Conversations this gateway is currently handling, grouped by channel."
Style="{StaticResource CaptionTextBlockStyle}"
Foreground="{ThemeResource TextFillColorSecondaryBrush}"
TextWrapping="Wrap" Margin="0,0,0,4"/>
Expand Down Expand Up @@ -100,7 +100,7 @@
Text="No active sessions"
Style="{StaticResource BodyStrongTextBlockStyle}"
HorizontalAlignment="Center"/>
<TextBlock Text="Sessions appear here when a channel is connected and traffic is flowing."
<TextBlock x:Uid="SessionsPage_EmptySubtitle" Text="Sessions appear here when a channel is connected and traffic is flowing."
Style="{StaticResource CaptionTextBlockStyle}"
Foreground="{ThemeResource TextFillColorSecondaryBrush}"
TextWrapping="Wrap" TextAlignment="Center"
Expand Down Expand Up @@ -184,11 +184,11 @@
<StackPanel Grid.Row="2" Grid.Column="1"
Orientation="Horizontal" Spacing="4"
VerticalAlignment="Center">
<Button Tag="{Binding Key}"
<Button x:Uid="SessionsPage_OpenChat"
Tag="{Binding Key}"
Click="OnOpenChat"
Style="{StaticResource AccentButtonStyle}"
Content="Open chat"
ToolTipService.ToolTip="Open this session in Chat"
AutomationProperties.Name="Open in chat"/>
<Button Tag="{Binding Key}"
IsEnabled="{Binding CanEdit}"
Expand Down
4 changes: 2 additions & 2 deletions src/OpenClaw.Tray.WinUI/Pages/SkillsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
HorizontalAlignment="Stretch"
HorizontalContentAlignment="Stretch">
<Expander.Header>
<TextBlock x:Name="EnabledHeaderText" Text="Enabled"
<TextBlock x:Uid="SkillsPage_Enabled" x:Name="EnabledHeaderText" Text="Enabled"
Style="{StaticResource BodyStrongTextBlockStyle}"
VerticalAlignment="Center"/>
</Expander.Header>
Expand All @@ -39,7 +39,7 @@
HorizontalContentAlignment="Stretch"
Visibility="Collapsed">
<Expander.Header>
<TextBlock x:Name="DisabledHeaderText" Text="Disabled"
<TextBlock x:Uid="SkillsPage_Disabled" x:Name="DisabledHeaderText" Text="Disabled"
Style="{StaticResource BodyStrongTextBlockStyle}"
VerticalAlignment="Center"/>
</Expander.Header>
Expand Down
4 changes: 2 additions & 2 deletions src/OpenClaw.Tray.WinUI/Pages/VoiceSettingsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@
Width="100" Visibility="Collapsed">
<StackPanel Orientation="Horizontal" Spacing="6">
<FontIcon x:Name="PiperPreviewIcon" Glyph="&#xE768;" FontSize="14"/>
<TextBlock x:Name="PiperPreviewLabel" Text="Preview"/>
<TextBlock x:Uid="VoiceSettingsPage_PiperPreviewLabel" x:Name="PiperPreviewLabel" Text="Preview"/>
</StackPanel>
</Button>
</StackPanel>
Expand All @@ -211,7 +211,7 @@
Width="140">
<StackPanel Orientation="Horizontal" Spacing="6">
<FontIcon x:Name="PreviewVoiceIcon" Glyph="&#xE768;" FontSize="14"/>
<TextBlock x:Name="PreviewVoiceLabel" Text="Preview Voice"/>
<TextBlock x:Uid="VoiceSettingsPage_PreviewVoiceLabel" x:Name="PreviewVoiceLabel" Text="Preview Voice"/>
</StackPanel>
</Button>
</StackPanel>
Expand Down
18 changes: 18 additions & 0 deletions src/OpenClaw.Tray.WinUI/Strings/en-us/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4514,4 +4514,22 @@ On your gateway host (Mac/Linux), run:
</data>
<data name="HubWindow_Advanced.Content" xml:space="preserve">
<value>Advanced</value>
</data>
<data name="AgentEventsPage_LiveText.Text" xml:space="preserve">
<value>Live</value>
</data>
<data name="SessionsPage_Subtitle.Text" xml:space="preserve">
<value>Conversations this gateway is currently handling, grouped by channel.</value>
</data>
<data name="SessionsPage_EmptySubtitle.Text" xml:space="preserve">
<value>Sessions appear here when a channel is connected and traffic is flowing.</value>
</data>
<data name="SessionsPage_OpenChat.Content" xml:space="preserve">
<value>Open chat</value>
</data>
<data name="VoiceSettingsPage_PiperPreviewLabel.Text" xml:space="preserve">
<value>Preview</value>
</data>
<data name="VoiceSettingsPage_PreviewVoiceLabel.Text" xml:space="preserve">
<value>Preview Voice</value>
</data></root>
18 changes: 18 additions & 0 deletions src/OpenClaw.Tray.WinUI/Strings/fr-fr/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4466,4 +4466,22 @@ Sur votre hôte passerelle (Mac/Linux), exécutez :
</data>
<data name="HubWindow_Advanced.Content" xml:space="preserve">
<value>Avancé</value>
</data>
<data name="AgentEventsPage_LiveText.Text" xml:space="preserve">
<value>Live</value>
</data>
<data name="SessionsPage_Subtitle.Text" xml:space="preserve">
<value>Conversations actuellement gérées par cette passerelle, regroupées par canal.</value>
</data>
<data name="SessionsPage_EmptySubtitle.Text" xml:space="preserve">
<value>Les sessions s'affichent ici lorsqu'un canal est connecté et que le trafic circule.</value>
</data>
<data name="SessionsPage_OpenChat.Content" xml:space="preserve">
<value>Ouvrir le chat</value>
</data>
<data name="VoiceSettingsPage_PiperPreviewLabel.Text" xml:space="preserve">
<value>Aperçu</value>
</data>
<data name="VoiceSettingsPage_PreviewVoiceLabel.Text" xml:space="preserve">
<value>Aperçu de la voix</value>
</data></root>
18 changes: 18 additions & 0 deletions src/OpenClaw.Tray.WinUI/Strings/nl-nl/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4467,4 +4467,22 @@ Voer op uw gateway-host (Mac/Linux) uit:
</data>
<data name="HubWindow_Advanced.Content" xml:space="preserve">
<value>Geavanceerd</value>
</data>
<data name="AgentEventsPage_LiveText.Text" xml:space="preserve">
<value>Live</value>
</data>
<data name="SessionsPage_Subtitle.Text" xml:space="preserve">
<value>Gesprekken die deze gateway momenteel afhandelt, gegroepeerd per kanaal.</value>
</data>
<data name="SessionsPage_EmptySubtitle.Text" xml:space="preserve">
<value>Sessies verschijnen hier wanneer een kanaal is verbonden en er verkeer stroomt.</value>
</data>
<data name="SessionsPage_OpenChat.Content" xml:space="preserve">
<value>Chat openen</value>
</data>
<data name="VoiceSettingsPage_PiperPreviewLabel.Text" xml:space="preserve">
<value>Voorbeeld</value>
</data>
<data name="VoiceSettingsPage_PreviewVoiceLabel.Text" xml:space="preserve">
<value>Stem bekijken</value>
</data></root>
17 changes: 17 additions & 0 deletions src/OpenClaw.Tray.WinUI/Strings/zh-cn/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4466,5 +4466,22 @@
</data>
<data name="HubWindow_Advanced.Content" xml:space="preserve">
<value>高级</value>
</data> <data name="AgentEventsPage_LiveText.Text" xml:space="preserve">
<value>Live</value>
</data>
<data name="SessionsPage_Subtitle.Text" xml:space="preserve">
<value>此网关当前处理的对话，按频道分组。</value>
</data>
<data name="SessionsPage_EmptySubtitle.Text" xml:space="preserve">
<value>当频道连接且流量流动时，会话会出现在此处。</value>
</data>
<data name="SessionsPage_OpenChat.Content" xml:space="preserve">
<value>打开聊天</value>
</data>
<data name="VoiceSettingsPage_PiperPreviewLabel.Text" xml:space="preserve">
<value>预览</value>
</data>
<data name="VoiceSettingsPage_PreviewVoiceLabel.Text" xml:space="preserve">
<value>预览语音</value>
</data></root>

17 changes: 17 additions & 0 deletions src/OpenClaw.Tray.WinUI/Strings/zh-tw/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4466,5 +4466,22 @@
</data>
<data name="HubWindow_Advanced.Content" xml:space="preserve">
<value>進階</value>
</data> <data name="AgentEventsPage_LiveText.Text" xml:space="preserve">
<value>Live</value>
</data>
<data name="SessionsPage_Subtitle.Text" xml:space="preserve">
<value>此網關目前處理的對話，依頻道分組。</value>
</data>
<data name="SessionsPage_EmptySubtitle.Text" xml:space="preserve">
<value>當頻道連接且流量流通時，工作階段會顯示在此處。</value>
</data>
<data name="SessionsPage_OpenChat.Content" xml:space="preserve">
<value>開啟聊天</value>
</data>
<data name="VoiceSettingsPage_PiperPreviewLabel.Text" xml:space="preserve">
<value>預覽</value>
</data>
<data name="VoiceSettingsPage_PreviewVoiceLabel.Text" xml:space="preserve">
<value>預覽語音</value>
</data></root>

2 changes: 1 addition & 1 deletion src/OpenClaw.Tray.WinUI/Windows/HubWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
Tapped="OnTitleBarStatusTapped">
<StackPanel Orientation="Horizontal" Spacing="6">
<Ellipse x:Name="TitleStatusDot" Width="8" Height="8" VerticalAlignment="Center" Fill="Gray"/>
<TextBlock x:Name="TitleStatusText" Text="Disconnected"
<TextBlock x:Uid="HubWindow_Disconnected" x:Name="TitleStatusText" Text="Disconnected"
FontSize="11" VerticalAlignment="Center" MinWidth="80"
Foreground="{ThemeResource TextFillColorSecondaryBrush}"/>
</StackPanel>
Expand Down
4 changes: 4 additions & 0 deletions tests/OpenClaw.Tray.Tests/LocalizationValidationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,10 @@ public class LocalizationValidationTests
"SandboxPage_1MiB.Content",
"SandboxPage_64MiB.Content",
"SandboxPage_SystemRun.Text",
// "Live" indicator label — internationally recognized UI term used
// in broadcast, streaming, and real-time status indicators worldwide.
// No translation provides additional clarity; kept invariant.
"AgentEventsPage_LiveText.Text",
};

private static readonly string[] RequiredRuntimeOnboardingKeys =
Expand Down