feat: localize XAML and code-behind strings#558
Conversation
Add x:Uid attributes to all 57 elements in CronPage.xaml that had hardcoded Text, Content, PlaceholderText, Title, or Message properties. The corresponding .resw entries already exist in all 5 locale files (en-us, fr-fr, nl-nl, zh-cn, zh-tw). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add x:Uid to 69 XAML elements across 7 pages (CronPage, AgentEventsPage, SessionsPage, SkillsPage, VoiceSettingsPage, HubWindow, SandboxPage) - Replace ~280 hardcoded C# strings with LocalizationHelper.GetString() in ChatPage, ConnectionPage, ChannelsPage, ConnectionStatusWindow, CronPage, AgentEventsPage, SchemaConfigEditor - Add all resource keys to 5 locales (en-us, fr-fr, nl-nl, zh-cn, zh-tw) - Fix CronPage.xaml encoding (Windows-1252 → UTF-8 em dash) - Add brand/loanword invariants (Tailscale, OK, via SSH) to test allowlist Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Codex review: needs changes before merge. Reviewed June 3, 2026, 5:52 PM ET / 21:52 UTC. Summary Reproducibility: yes. for the blocking review finding: the PR head adds x:Uid to the WSL host-control XAML, but ApplyGatewayHostAccess immediately overwrites those TextBlocks with hardcoded English. The submitted Chinese Connection page screenshot also shows that English fallback in the live UI. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Mantis proof suggestion Risk before merge
Maintainer options:
Copy recommended automerge instructionNext step before merge
Security Review findings
Review detailsBest possible solution: Land this after dynamic WSL host-control text is routed through resources, locale key parity is preserved, and the PR body shows the required full build, shared tests, tray tests, and representative localized UI proof. Do we have a high-confidence way to reproduce the issue? Yes for the blocking review finding: the PR head adds x:Uid to the WSL host-control XAML, but ApplyGatewayHostAccess immediately overwrites those TextBlocks with hardcoded English. The submitted Chinese Connection page screenshot also shows that English fallback in the live UI. Is this the best way to solve the issue? No: x:Uid alone is not enough for text that code-behind mutates after load. The narrower maintainable fix is to localize those assignments with LocalizationHelper resource keys and preserve the existing WSL control behavior. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against be64bea0bec8. Label changesLabel changes:
Label justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>


Summary
Validation