chore(deps): refresh Go toolchain and cookie dependencies - #62
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs changes before merge. Reviewed September 4, 2026, 4:23 AM ET / 08:23 UTC. ClawSweeper reviewWhat this changesThe PR selects Go 1.26.8 while retaining the Go 1.26.7 minimum, updates three indirect dependencies and the Pages deployment action, and adjusts installation documentation and release notes. Merge readiness⛔ Needs changes before merge - 2 items remain Keep open: this useful maintenance update is absent from main. Review found one minor installation-documentation error and no demonstrated runtime regression. Priority: P3 Review scores
Verification
How this fits togetherspogo is a Spotify command-line client whose cookie importer reads browser databases into a local credential cache. Go dependencies support that importer, while a separate Pages workflow publishes the installation documentation. flowchart LR
A[Go toolchain and dependency pins] --> B[Built spogo CLI]
B --> D[Browser cookie import]
C[Browser cookie database] --> D
D --> E[Local cookie cache]
E --> F[Spotify commands]
G[Documentation build] --> H[Pages deployment]
Before merge
Findings
Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Retain the compatible dependency refresh and distinguish versioned installation from checkout-specific toolchain selection in the installation guide. Do we have a high-confidence way to reproduce the issue? Yes, for the documentation mismatch: Go's source shows that versioned installation outside a checkout does not enforce the downloaded module's preferred toolchain. No runtime regression was reproduced. Is this the best way to solve the issue? Yes, the dependency refresh is focused and preserves the declared minimum; its installation explanation needs to distinguish the two build paths. Full review comments:
Overall correctness: patch is correct AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 87a990da7e29. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: chore(deps): refresh Go toolchain and cookie dependencies This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
|
Squash-merged as e89c46f. The merge tree matches the reviewed candidate exactly, with the original main commit as its single parent. Validation passed: 90.4% coverage, race tests, lint, deadcode, Go 1.26.7/1.26.8 native builds, Linux/Windows cross-builds, and built-CLI import/status/clear against a synthetic Firefox cookie database. The docs-only follow-up rebuilt the site and checked its rendered installation text. Full-candidate isolated P2 review passed before commit and landing. Postmerge CI, CodeQL, Pages, and the dependency graph update passed. The published install page returns HTTP 200 and correctly scopes the Go 1.26.8 preference to checkout builds. No CI reruns were needed. The minimum remains Go 1.26.7, and libc remains pinned to SQLite's required 1.75.6. Cookie integration proof used synthetic data and made no Spotify service requests. |
Refresh the Go 1.26 build toolchain and compatible indirect dependencies used by browser-cookie import. The module keeps Go 1.26.7 as its minimum and selects Go 1.26.8 for repository builds; installation documentation and the existing Unreleased entry now describe that distinction.
modernc.org/sqlitefrom 1.57.0 to 1.58.0,golang.org/x/cryptofrom 0.55.0 to 0.56.0, andgithub.com/google/pproffrom4932ad3515eatod6c3cb2f37ec.modernc.org/libc1.75.6, matching SQLite's explicitly required companion version.actions/deploy-pagesaction from 5.0.0 to 5.0.1 for its deployment-polling backoff improvements.Validation passed with Go 1.26.8:
./scripts/check-coverage.sh 90— 90.4% total coverage.go test -race ./...— passed../scripts/lint.sh— golangci-lint 2.13.2, zero issues.go run golang.org/x/tools/cmd/deadcode@v0.49.0 -test ./...— no findings.go mod verifyandgit diff --check— passed.node scripts/build-docs-site.mjs— passed.Built-CLI integration proof used an isolated Firefox SQLite database containing three synthetic Spotify cookies.
auth importread the database through SweetCookie/SQLite, saved all three cookies with mode 0600, andauth statusread the persisted file and reported all expected cookie flags.auth clearremoved the cache and cleared its config entry; the source database remained unchanged and all commands produced empty stderr. Bash, zsh, and fish completion also passed. This proof used no real account credentials or Spotify requests. The Pages action was checked against upstream source and its release tag; no deployment was triggered.The built-CLI proof was repeated with a binary built from the clean committed worktree at
3026c4440773677947afe177d080bd06af5d0d50. Isolated Codex autoreview completed successfully through P2 with no actionable findings.The documentation follow-up scopes Go 1.26.8 selection to checkout builds with automatic toolchain selection enabled. Versioned
go install ...@latestretains the Go 1.26.7 minimum without promising the downloaded module's preferred toolchain. The docs site was regenerated and its rendered install page checked; production code and dependency pins are unchanged by this follow-up.