Skip to content

Fix auth #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
peterdudfield merged 6 commits into from
Dec 19, 2025
Merged

Fix auth #158

peterdudfield merged 6 commits into from
Dec 19, 2025

Conversation

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 19, 2025 •
edited
Loading

Pull Request

Description

  • fix for auth0 sub/id. Needed to remove the extra string of 'google-oauth2|' and 'auth|'

Fixes for #137 and reference for #155

How Has This Been Tested?

  • CI tests
  • tested it locally with auth0

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from braddf December 19, 2025 12:12
braddf
braddf approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@braddf braddf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks better thanks, good to go 👍

@peterdudfield peterdudfield merged commit 7682886 into main Dec 19, 2025
8 checks passed
@peterdudfield peterdudfield deleted the fix-auth branch December 19, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braddf braddf braddf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterdudfield @braddf