Skip to content

Conversation

@TheOneRing
Copy link
Contributor

@TheOneRing TheOneRing commented Feb 9, 2026

26-02-09 14:34:20:555 [ info sync.connectionvalidator ]:	System proxy lookup done NoProxy """:0" ["Tunnel Listen UDP SctpTunnel SctpListen"] for "Test@opencloud..de" duration(0h, 0min, 0s, 251ms)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GUI connection validation flow to modernize system proxy lookup and log how long that lookup takes before proceeding with server/auth checks.

Changes:

  • Replaced ClientProxy::lookupSystemProxyAsync(...) + SystemProxyRunnable with a QtConcurrent::run(...) + QFutureWatcher flow in ConnectionValidator::checkServer().
  • Removed now-unused proxy-lookup API and helper formatting (printQNetworkProxy) from ClientProxy.
  • Added duration logging for system proxy lookup completion.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/gui/connectionvalidator.h Removes the old systemProxyLookupDone(...) slot declaration.
src/gui/connectionvalidator.cpp Implements system proxy lookup via QtConcurrent/QFutureWatcher and logs elapsed time.
src/gui/clientproxy.h Removes async lookup API and SystemProxyRunnable declaration.
src/gui/clientproxy.cpp Removes async lookup implementation and switches proxy logging away from printQNetworkProxy.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheOneRing TheOneRing merged commit 3dd1bc2 into main Feb 9, 2026
11 of 13 checks passed
@TheOneRing TheOneRing deleted the work/proxy branch February 9, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants