Repository navigation
docs: finish sport-scoping framing in spec doc; recover lost review edits - #37
Merged
Merged
Conversation
…dits Two review fixes from RFC 0003 were lost when the merge squashed a pre-push branch state (commit 13fa6ea never reached origin). Re-applies them plus the remaining basketball-only framing the .adoc still carried: - H1 title + intro + motivation: 'basketball drill diagrams' -> 'team-sport coaching diagrams' (invasion sports, basketball first) — matching the README, schema description, and the == Sport section. - Action-type reference table now lists the reserved types (tackle/clear/ faceoff/check) and notes the valid subset depends on sport. - soccer fixture: player no longer passes to themselves (adds offense_8 as the teammate target; nr 1-9 is the current per-team cap). Changelog v1.0.0 historical entries left as-is (they describe that release). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the documentation for RFC 0003 / v1.2.0. Two review edits were lost when PR #36's squash merge captured a pre-push branch state (the fix commit never reached origin), plus the
.adocstill carried basketball-only framing in places the== Sportsection didn't cover.Changes
description, and the== Sportsection.tackle/clear/faceoff/checkand notes the valid subset depends onsport.offense_8;nr1-9 is the current per-team cap).Changelog v1.0.0 historical entries intentionally left unchanged (they describe that release accurately).
Test Plan
npm test— all examples valid (incl. corrected soccer fixture), 15 invalid rejected, positions + sport tests pass🤖 Generated with Claude Code