Repository navigation
docs: make examples v1.2.0-conformant (sport field, intensity, fix continuous-ball-screen) - #39
Merged
Merged
Conversation
…uous-ball-screen) - Add explicit sport: basketball to the four core examples (best practice for v1.2.0; sport becomes required in v2). quick-mode deliberately stays sport-less as a living demonstration that sport-less documents remain valid (back-compat). - continuous-ball-screen was an untracked file that never validated (its meta.id was not a UUID). Fixed the id, added sport + per-action intensity, and now track it — the whole examples set validates for the first time. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the example set up to v1.2.0 best practice.
Changes
sport: "basketball"added to the four core examples (3-man-weave, based-on-references, pick-and-roll, transition-3v2) — the recommended v1.2.0 practice (sport becomes required in v2). Documents withoutsportstay valid.quick-modedeliberately left sport-less — a living demonstration in the example set that back-compat (sport-absent = basketball) still validates.duration_ms→ per-actionintensityin the three examples that used it (movement_intensity for move/cut/dribble, ball_intensity for pass/shoot; screen/rebound untouched).continuous-ball-screen.ocf.json: was an untracked file that never validated (itsmeta.idwasn't a UUID). Fixed the id, addedsport+ per-actionintensity, and now tracked — so the entire examples set validates for the first time.Test Plan
npm test— all 8 examples valid (incl. continuous-ball-screen), 15 invalid rejected, positions + sport tests passduration_msremains; every intensity-taking action carries intensity; quick-mode intentionally sport-less🤖 Generated with Claude Code