Repository navigation
Site A: render PlantUML diagrams on the spec page - #46
Merged
Merged
Conversation
… diagrams, arc42 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Verified public kroki.io renders PlantUML but 500s on Mermaid; spec uses only PlantUML, arc42 uses only Mermaid. Split into two renderers behind one façade.
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan A of the site redesign. Renders the spec page's PlantUML blocks as inline, responsive SVG at build time — they currently show as raw
@startumltext.Also lands the site-redesign design doc and Plan A (first of four sequential plans).
What
site/src/lib/diagram.mjs— a small façaderenderDiagram(type, source); Plan A implements theplantumlbranch (POST to Kroki, returns SVG, throws on non-OK = build-fails-loud). Mermaid/arc42 come in Plan D.build-adoc.mjspost-processes the asciidoctor HTML:literalblocks holding@startumlare replaced with the rendered SVG./docs/spec(.diagram-svgstyling via:global).Verified
diagram3/3,replace-plantuml2/2.npm run build:adocembeds 2<svg>diagrams, 0 leftover@startuml.npm run build+ built/docs/specpage contain the SVGs.Note
Verified fact: public
kroki.iorenders PlantUML but 500s on Mermaid; the spec uses only PlantUML (arc42 uses only Mermaid → localmmdcin Plan D). Design doc updated accordingly.Leaving the merge to you (as agreed). The next plans (B nav/homepage, C Try-it + sport pages, D arc42) build on this.
🤖 Generated with Claude Code