Repository navigation
Site D: arc42 architecture docs on the site (client-side Mermaid) - #50
Merged
Merged
Conversation
…d-time Verified: @mermaid-js/mermaid-cli install fails (headless Chromium), deploy workflow has no browser. mermaid@11 ESM loads from jsDelivr (200, CORS *). So arc42 Mermaid renders client-side; PlantUML stays Kroki build-time SVG.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…pi@1.11.3) The marked-added lock was inconsistent (nested @emnapi 1.11.1 but missing the top-level 1.11.3 that npm ci on Linux resolves). Rebuilt the lock from scratch; npm ci now passes and the build is unchanged (35 pages).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan D — the final piece of the site redesign. Base is main (not stacked). Pulls the validator's arc42 architecture docs onto the site under Build.
What
opencoachingformat/ocf-validatorat a pinned commit (OCF_ARC42_COMMIT, separate from the validator pin), renders them withmarked, and publishes them under Build → Architecture: an overview TOC + one page per section viagetStaticPaths.@mermaid-js/mermaid-cli(mmdc) is a fragile heavyweight build dep — its install downloads headless Chromium and failed outright here, and the deploy workflow has no browser. So arc42's Mermaid blocks become<pre class="mermaid">+ amermaid@11ESM module script (jsDelivr, 200/CORS*) that renders in the visitor's browser. PlantUML (spec page, Plan A) stays build-time Kroki SVG. Design doc updated to reflect this fact-driven revision.Verified
npm run build: 35 pages;/build/architecture/overview + 13 section pages resolve.<pre class="mermaid">+ the mermaid module script; overview is mermaid-free; no leftover raw```mermaidfences.mermaid-marked7/7 (mermaid fences → raw-source<pre>, non-mermaid stays escaped; index sort). No network in tests./build/architecture/added to axe (mermaid-free overview); section pages excluded to avoid flaky client-render timing.set:htmlof remote markdown is bounded by the trusted repo + pinned commit (no<script>in output) — noted as accepted risk.Leaving the merge to you. This completes the 4-plan redesign (A diagrams, B nav/homepage, C Try-it+sports, D arc42).
🤖 Generated with Claude Code