-
Notifications
You must be signed in to change notification settings - Fork 4
Allow creation of virtual environment during the CMake configuration step #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@compor I checked out this branch on my desktop machine (fedora) and after running I get the following error: The output of my @superlopuh are you able to reproduce this error on your machine? |
|
What happens if you activate the venv before running the command? |
|
The same thing. I did and I get the same output: |
|
sorry, did you do |
|
what happens if you do |
|
Sorry, I made a typo. I ran |
|
Yay! |
|
@EmilySillars thank you for checking, this is the expected behavior. |
This PR is working towards #149 (a few PRs on the way) by:
venvdir) from within the top-level CMake file.It eliminates the need to create a virtual environment (venv) before issuing the CMake configuration, but it does not prevent the user from creating one manually if desired.
Update: Forgot to mention that this maintains the current functionality, and it is orthogonal with the current open PRs wrt CMake changes.
CC: @EmilySillars