Skip to content

Provide guidelines for copyright notices - #159

Merged
sudo-bmitch merged 1 commit into
opencontainers:mainfrom
sudo-bmitch:pr-guideline-copyright
Jul 9, 2026
Merged

Provide guidelines for copyright notices#159
sudo-bmitch merged 1 commit into
opencontainers:mainfrom
sudo-bmitch:pr-guideline-copyright

Conversation

@sudo-bmitch

Copy link
Copy Markdown
Contributor

Fixes #151.

Comment thread guidelines/copyright.md Outdated
> Copyright the Open Container Initiative Contributors.

Software copied from third parties should include the original copyright headers.
Additional copyright headers are permitted in situations where a significant contribution is made by a source that would like to be recognized.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've typically seen that in an AUTHORS file rather than directly in the copyright header of a single file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a concession to #151 (comment)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm -1 -- I don't think we should encourage this practice.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to phrase this that would be better and in line with the discussion on #151? Otherwise, can we continue the thread there? I don't want to submit a PR that's different from the issue consensus.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the latest discussion in the issue, I've deleted the lines so that it's not explicitly recommended. We still have the link to the LF guidance that we can fall back on for any exceptions.

Signed-off-by: Brandon Mitchell <git@bmitch.net>
@sudo-bmitch

Copy link
Copy Markdown
Contributor Author

@mikebrow @tianon @cyphar I see you've reviewed the child PRs. PTAL at this one when you have a chance.

@mikebrow mikebrow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon tianon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudo-bmitch
sudo-bmitch merged commit 25ba163 into opencontainers:main Jul 9, 2026
1 check passed
@sudo-bmitch
sudo-bmitch deleted the pr-guideline-copyright branch July 9, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guidance needed for copyright headers

4 participants