Fix cleanup orphans, private manageUrl, and related production risks - #1
Draft
leoisadev1 wants to merge 3 commits into
Draft
Fix cleanup orphans, private manageUrl, and related production risks#1leoisadev1 wants to merge 3 commits into
leoisadev1 wants to merge 3 commits into
Conversation
Purge and expiry no longer drop ledger rows when R2 delete fails; sites drain in bounded batches with self-scheduling and backoff. Deploy/update/ image metadata failures compensate by deleting the just-stored blob, and OAuth register/token plus grant cleanup are rate-limited and indexed. Claim cannot steal an already-owned site; listMine and imageCount stay bounded. Co-authored-by: Leo <leoisadev1@users.noreply.github.com>
manageUrl and /:slug?t= use getBySlugForManager so private deploys match the skill's promise. Also ignore local .wrangler state in the root gitignore. Co-authored-by: Leo <leoisadev1@users.noreply.github.com>
Static checks for retry-safe purge, write-path compensate, claim guard, OAuth limits, and bounded queries, plus a few runtime helper smoke tests. Co-authored-by: Leo <leoisadev1@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the production-risk audit fixes for AgentDrop:
getBySlugForManagerletsmanageUrl?t=and/{slug}?t=work for edit-token holders (matches the skill).expiresAt; grant cleanup self-schedules when saturated.listMine/imageCount,healthCheckargs, remove tracked.wranglerstate + emptynonexistent, root.gitignoreignores.wrangler/.Test plan
bun run packages/backend/scripts/verify-audit-fixes.ts— contract checks passedbunx tsc -p packages/backend/convex/tsconfig.json --noEmitbunx tsc --noEmitinapps/web(after regeneratingrouteTree.gen.tslocally)manageUrllogged out → manage UI worksPOST /oauth/register→ 429Notes
Email verification remains off (
requireEmailVerification: false) as a documented follow-up — enabling it needs an email provider.