Skip to content

fix(frontend): members page and create-risk modal crash — imports lost in merge 269e54fc #840

Closed
#845
Closed
fix(frontend): members page and create-risk modal crash — imports lost in merge 269e54fc#840
#845
Labels
area:frontendReact, /srcpriority:P0-criticalProduction broken or exposed — work nowstatus:in-reviewPR opentype:bugSomething is broken
Milestone
ds-v1

Description

@alex-dembele
alex-dembele
opened on Sep 29, 2026

Problem

On master, the members page and the create-risk modal throw a ReferenceError as soon as they render:

  • frontend/src/features/organization/MembersView.tsx:487 uses DeleteButton, but the file never imports it.
  • frontend/src/features/risks/CreateRiskModal.tsx:241 uses ScrollProgress, but the file never imports it.

Both imports were lost when a merge conflict was resolved: 269e54fc, "Merge branch 'master' into feat/751-phase2-feedback", which then shipped with #823. vite build doesn't type-check, so the build still passes.

Evidence (on master @ 234c342c)

npx tsc -b
src/features/organization/MembersView.tsx(487,30): error TS2304: Cannot find name 'DeleteButton'.
src/features/risks/CreateRiskModal.tsx(241,16): error TS2304: Cannot find name 'ScrollProgress'.

npx vitest run → Test Files 3 failed | 86 passed · Tests 11 failed | 849 passed
(members.test.tsx ×9, CreateRiskModal.test.tsx ×1, App.integration ×1)

Acceptance criteria

  1. npx tsc -b reports no TS2304 error on either file.
  2. members.test.tsx and CreateRiskModal.test.tsx pass.
  3. The members page and the create-risk modal render in a real browser.

Definition of Done

A PR restores both imports, and the verification output is pasted in it.

Activity

  1. alex-dembele
    added this to the ds-v1 milestone on Sep 29, 2026
  2. alex-dembele
    added
    type:bugSomething is broken
    area:frontendReact, /src
    priority:P0-criticalProduction broken or exposed — work now
    status:in-progressAn agent is working it
    status:in-reviewPR open
    and removed
    status:in-progressAn agent is working it
    on Sep 29, 2026

  3. alex-dembele commented on Sep 29, 2026

    @alex-dembele
    alex-dembele
    on Sep 29, 2026
    MemberAuthor

    work — 2026-09-29

    Done — PR #845 (fix/840-restore-lost-imports). It restores DeleteButton in MembersView.tsx and ScrollProgress in CreateRiskModal.tsx.

    Verified

    • tsc -b is clean.
    • vitest: 87 files / 873 passed; master had 11 failing.
    • Live on a throwaway stack (a server built from the branch, Postgres 16 and Redis 7):
      • the members page renders the revoke button;
      • "Nouveau risque" opens the dialog;
      • counter-proof: without the imports, ReferenceError on both screens.

    Criteria — 1 ✅ · 2 ✅ · 3 ✅

    Next — owner review and merge of #845. #825 will also need a rebase onto master (its shared/ds/index.ts conflicts with phase 2's exports).

    Blocked on — @owner review

  4. alex-dembele
    added a commit that references this issue on Oct 1, 2026

    Merge pull request #845 from opendefender/fix/840-restore-lost-imports

    f486e9f
  5. alex-dembele
    closed this as completedin #845on Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:frontendReact, /srcpriority:P0-criticalProduction broken or exposed — work nowstatus:in-reviewPR opentype:bugSomething is broken

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions