debt(frontend): lint errors on master: any in EditRiskModal, setState in effects, dead GlobalShortcuts import

[alex-dembele]

Problem

npx eslint reports errors on master in three files nobody is currently working on. One of them breaks an absolute rule of the project (rule 5, zero any). The others are a dead import and two setState calls made synchronously inside a useEffect, which cost an extra render.

Found during #755 by linting the master versions of the files (git show master:<file> | npx eslint --stdin).

Acceptance criteria

1. frontend/src/features/risks/components/EditRiskModal.tsx has no any: the risk prop, the asset map callback and the submit handler are typed.
2. frontend/src/features/risks/RiskWeightsSettings.tsx no longer copies server data into state with setState inside an effect (react-hooks/set-state-in-effect).
3. frontend/src/App.tsx: the ?guided=1 deep link no longer calls setNewRiskOpen synchronously in an effect, and the unused GlobalShortcuts import is removed. The component it imported was replaced by ShortcutsOverlay + useHotkeys in Implement UX primitives: undoableDelete, ImpactDialog, Hint, ProgressState, PremiumPeek #165, so it is deleted rather than left orphaned.
4. npx eslint reports zero errors on these three files; tsc -b and the full vitest run stay green.
5. Behaviour is unchanged and verified live: editing a risk saves, the weights page loads and saves the server's weights, and /risks?guided=1 opens the create-risk dialog once and strips the parameter.

Definition of Done

Criteria 1–5 verified. PR open with Closes #<n>.

[alex-dembele]

frontend-react — 2026-10-01

Done — EditRiskModal.tsx typed (EditableRisk, no any); RiskWeightsSettings.tsx derives weights from the query and keeps only edits in state; App.tsx opens the guided dialog during render, and the effect only strips the URL; GlobalShortcuts import and dead component removed. New RiskWeightsSettings.test.tsx.
Verified — eslint: 0 errors on the three files; tsc -b ok; vitest run → 102 files, 948 tests passed. Live: guided link opens one dialog and strips the param; edit → PATCH 200; weights page loads the server's values.
Criteria — 1 ✅ · 2 ✅ · 3 ✅ · 4 ✅ · 5 ✅, except the weights save, which is verified by unit test only: the sliders unlock only for admin, not for the seeded owner. Same gate as on master.
Next — owner review of PR. Possible follow-up: should an owner be able to edit the weights?
Blocked on — nothing

[alex-dembele]

Found while checking #872: npx eslint . --max-warnings=0 fails on master (e28925b4) in three more files, on top of the ones this issue lists:

• src/features/auth/MFAEnrollmentBanner.tsx:61: react-refresh/only-export-components;
• src/features/auth/MFAPostAhaPrompt.tsx:64: react-hooks/set-state-in-effect (setOpen(true) in an effect);
• src/lib/observability.ts:30: an unused eslint-disable directive (a warning).

#872 does not touch these files.