Skip to content

fix(auth): master does not build — restore the #866 SAML handler (#881) - #882

Merged
alex-dembele merged 1 commit into
masterfrom
fix/881-saml-merge-build
Oct 2, 2026
Merged

alex-dembele merged 1 commit into
masterfrom
fix/881-saml-merge-build

Conversation

@alex-dembele

Copy link
Copy Markdown
Member

Closes #881

master does not build. Merge e86df5cd resolved the #866/#803 conflict in saml2_handler.go by keeping #866's imports and the old, unsigned SAML2ACS body from #803. internal/handler didn't compile, so none of its tests were running.

This PR restores the file exactly as #866 left it (git show 069b3db8:backend/internal/handler/saml2_handler.go): both SAML entry points refuse every request. #803's SSO session code lives in other files and is untouched.

Don't "fix" this by adding the missing imports instead. That would put the ACS that accepts unsigned assertions back into service.

Verification

  • On master 14f26e8e: go build ./... → 11 errors in saml2_handler.go (undefined: base64, xml, domain, …).
  • On this branch: go build ./... && go vet ./... && go test ./... -race → BUILD_OK · VET_OK · TEST_OK, 80 packages ok, 0 FAIL.
  • TestSAML2ACS_RefusesAWellFormedSuccessResponse, TestSAML2ACS_RefusesAnEmptyPost, TestSAML2InitiateLogin_RedirectsToTheLoginScreen, TestIssueSSOSession_SAMLExitSetsCookiesAndLandsHome, TestIssueSSOSession_SAMLExitFailureRedirectsToLogin → PASS.

Honest remainders

Merge e86df5c kept #866's imports and header but #803's old SAML2ACS
body, so internal/handler no longer compiled. Restoring the file from
069b3db brings back the refuse-everything ACS.

Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(auth): master does not build — the #866 merge kept the unsigned SAML ACS body

1 participant