Repository navigation
fix(auth): master does not build — restore the #866 SAML handler (#881) - #882
Merged
Merged
Conversation
This was referenced Oct 2, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #881
master does not build. Merge
e86df5cdresolved the #866/#803 conflict insaml2_handler.goby keeping #866's imports and the old, unsignedSAML2ACSbody from #803.internal/handlerdidn't compile, so none of its tests were running.This PR restores the file exactly as #866 left it (
git show 069b3db8:backend/internal/handler/saml2_handler.go): both SAML entry points refuse every request. #803's SSO session code lives in other files and is untouched.Don't "fix" this by adding the missing imports instead. That would put the ACS that accepts unsigned assertions back into service.
Verification
14f26e8e:go build ./...→ 11 errors insaml2_handler.go(undefined: base64,xml,domain, …).go build ./... && go vet ./... && go test ./... -race→ BUILD_OK · VET_OK · TEST_OK, 80 packagesok, 0FAIL.TestSAML2ACS_RefusesAWellFormedSuccessResponse,TestSAML2ACS_RefusesAnEmptyPost,TestSAML2InitiateLogin_RedirectsToTheLoginScreen,TestIssueSSOSession_SAMLExitSetsCookiesAndLandsHome,TestIssueSSOSession_SAMLExitFailureRedirectsToLogin→ PASS.Honest remainders
provisionSAML2UserandapplyGroupRoleMappinggo away with the old body, as they did in security(auth): SAML endpoints refuse every request until assertions are verified #866.