chore(frontend): clear the two eslint errors in the auth feature (#878) - #885
Merged
Merged
Conversation
Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #878
MFAEnrollmentBanner.tsx:copyForwas exported but imported nowhere, which trippedreact-refresh/only-export-components. It's now module-private. Nothing needed a new module, so criterion 4 has nothing to move.MFAPostAhaPrompt.tsx: the prompt was opened bysetOpen(true)inside an effect (react-hooks/set-state-in-effect). The decision is now taken while rendering, once per transition into eligibility (React's "adjust state while rendering" pattern). Only the side effect, writing the cooldown tolocalStorage, stays in an effect. No rule is disabled.Verification
npx eslint src/features/auth→ 0 problems (master: 2 errors).npx tsc -b --noEmit→ OK. Prettier → OK.npm run build→ built in 6.13s.npx vitest run→ 107 files, 993 tests passed, on two consecutive runs. A first run under heavy machine load showed 22 transient failures in unrelated files; it didn't reproduce, and master gives the same 993/993.mfaPostAhaPrompt.test.tsx(8 cases),mfaEnrollmentBanner*.test.tsx,exitTimerTokens.test.ts.MFAPostAhaPromptwith a pre-filled React Query cache; the harness was deleted before the commit):Honest remainders